-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Duplicate (Copy) Page functionality #13607
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
Hey @osullivanchris 👋 |
To create Pages with version conflicts for testing purposes you can use the following steps:
This scenario is extreme but seems to consistently produce conflicts. cc @mkevins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested on Pixel 3a (physical device). It is working as expected for all the described flows. Nice work Antonis! LGTM 👍
Hey @antonis, I must have missed this before the holidays. I think duplicating a scheduled or pending post is fine. I think the new duplicated post should behave like others - just being a plain draft with no schedule or pending status. Perhaps we need to tell the user in some way, is the only issue I can see. I just captured draft and published as two examples in the mock, but covering all statuses is even better. |
Hello @osullivanchris 👋 |
Fixes #13599
Description
This PR implements the "Duplicate page" functionality (already exists on Calypso) and is similar with the Duplicate Post functionality
To test
Duplicate published page
🔵 Tracked: site_pages_options_pressed, Properties: {"option_name":"copy","blog_id":174576032,"is_jetpack":false,"site_type":"blog"}
Duplicate draft page
🔵 Tracked: site_pages_options_pressed, Properties: {"option_name":"copy","blog_id":174576032,"is_jetpack":false,"site_type":"blog"}
Duplicate page with conflict
🔵 Tracked: site_pages_options_pressed, Properties: {"option_name":"copy","blog_id":174576032,"is_jetpack":false,"site_type":"blog"}
Edit page with conflict
Duplicate local page
Screenshots
PR submission checklist:
RELEASE-NOTES.txt
if necessary.