Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gutenberg-mobile release 1.43.0 #13560

Merged
merged 10 commits into from
Dec 12, 2020
Merged

Integrate gutenberg-mobile release 1.43.0 #13560

merged 10 commits into from
Dec 12, 2020

Conversation

jd-alexander
Copy link
Contributor

Description

This PR incorporates the 1.43.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#2874

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 8, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jd-alexander jd-alexander added this to the 16.4 milestone Dec 8, 2020
@jd-alexander jd-alexander marked this pull request as draft December 8, 2020 01:11
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 8, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@guarani guarani mentioned this pull request Dec 8, 2020
Merged
3 tasks
@guarani guarani marked this pull request as ready for review December 8, 2020 02:07
@jd-alexander jd-alexander mentioned this pull request Dec 11, 2020
Merged
3 tasks
@jd-alexander
Copy link
Contributor Author

jd-alexander commented Dec 12, 2020 •
edited
Loading

This PR can be merged as the lint failure is not related to this PR. A fix for this issue is currently in review.

@cameronvoell cameronvoell self-requested a review December 12, 2020 08:06
cameronvoell
cameronvoell approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved via wordpress-mobile/gutenberg-mobile#2874 (review). Should be ready to merge once we update the gutenberg-mobile ref to release merge on trunk

@guarani
Copy link
Contributor

guarani commented Dec 12, 2020

@hypest mentioned offline that it would be best to merge this since the linter error here happens on develop already and we'd rather merge this before any other PRs land on develop. I agree this sounds like a good idea.
I don't have access to merge this so would you mind merging @hypest?

@hypest hypest merged commit 0fac447 into develop Dec 12, 2020
@hypest hypest deleted the gutenberg/integrate_release_1.43.0 branch December 12, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jd-alexander @guarani @cameronvoell @hypest