Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release 1.42.1 (fix) #13550

Merged

Conversation

aforcier
Copy link
Contributor

@aforcier aforcier commented Dec 5, 2020

This is a follow-up to #13540, using the right gutenberg-mobile tag for release 1.42.1.

As far as I can tell, #13540 was tested with the right branch, but this final commit updating to the release tag hash accidentally used the tag for 1.42.0 instead of 1.42.1.

Comparing the previous tag in that PR (that it was tested with) to the one I'm using in this PR, you can see the change is only the tag update:

wordpress-mobile/gutenberg-mobile@3000ec...5d7a4d2

And that release/16.3 without this PR is actually incorrectly pointing to gutenberg-mobile 1.42.0:

https://github.com/wordpress-mobile/gutenberg-mobile/releases/tag/v1.42.0 (see that the hash is 6fed9e)

To test:

Should have already been tested in #13540, just check that this builds.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the commit hash and the story post icon fix. Thanks for catching this Alex!

@cameronvoell cameronvoell merged commit 4d9f50e into release/16.3 Dec 5, 2020
@cameronvoell cameronvoell deleted the gutenberg/integrate_release_1.42.1_take2 branch December 5, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants