Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Home Page Picker] Mark Theme Selection as Completed as part of the Site Creation Flow #13502

Closed
wants to merge 1 commit into from

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Nov 30, 2020

With the release of the home page picker #13409
We make users pick a theme during site creation. We thus need to mark the theme selection step as completed in the quick start tour screen.

To test:

Choose a theme

  • Create a site
  • Pick a theme
  • Take the tour
  • Notice "Choose a theme" is marked as completed

Skip site creation

  • Create a site
  • Select Skip on Choose a Design
  • Take the tour
  • Notice "Choose a theme" is in the checklist

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@antonis antonis changed the base branch from develop to release/16.3 November 30, 2020 20:36
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 30, 2020

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@antonis antonis changed the base branch from release/16.3 to develop November 30, 2020 20:37
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@antonis
Copy link
Contributor Author

antonis commented Nov 30, 2020

Closing in favor of #13503 (changed target)

@antonis antonis closed this Nov 30, 2020
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on the Skip and choose a design flows 👍

@antonis antonis deleted the issue/hpp-quickStartTheme branch November 30, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants