Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in MockingInterceptor.kt #13359

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix issues in MockingInterceptor.kt #13359

merged 1 commit into from
Nov 11, 2020

Conversation

malinajirka
Copy link
Contributor

Fixes issues in MockingInterceptor which are resulting in a build failure on develop.

To test:
Running CI tests should be enough.

PR submission checklist:

  • [X ] I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 16.2 milestone Nov 11, 2020
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

planarvoid
planarvoid approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@planarvoid planarvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@planarvoid planarvoid merged commit 125b398 into develop Nov 11, 2020
@planarvoid planarvoid deleted the fix-mocking-interceptor-issue branch November 11, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planarvoid planarvoid planarvoid approved these changes

Assignees
No one assigned
Labels
[Pri] High
Projects
None yet
Milestone
16.2
Development

Successfully merging this pull request may close these issues.
2 participants
@malinajirka @planarvoid