Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ube cannot view or interact with the classic block on jetpack sites #13148

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Ube cannot view or interact with the classic block on jetpack sites #13148

merged 4 commits into from
Oct 15, 2020

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Oct 15, 2020 •
edited
Loading

Gutenberg PR: WordPress/gutenberg#26168
Gutenberg mobile PR: wordpress-mobile/gutenberg-mobile#2730

To test:

  1. On the web, create a post with a classic block on a Jetpack site (we should use jurassic ninja to test the classic block on a jetpack site).
  2. Save or publish the post.
  3. In the app, open the post from the previous step in the block editor.
  4. Tap on the classic block.
  5. Tap on the classic block again.
  6. Select the option to "Edit using the web editor."
  7. Observe that classic block is presented and all HTML elements (navigation bar and other) are hidden.
  8. Check that WebView has a good block title (e.g. 'Edit Classic block')

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 15, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@marecar3 marecar3 changed the title Update gb-mobile reference Ube cannot view or interact with the classic block on jetpack sites Oct 15, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 15, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

cameronvoell
cameronvoell approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#26168 (review)

guarani
guarani approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build 77507 with a few scenarios (Jetpack connected with SSO off and on, Atomic and Simple sites), all working as expected on Samsung S10.

@marecar3 marecar3 merged commit 81e7be9 into gutenberg/integrate_release_1.38.1 Oct 15, 2020
@marecar3 marecar3 deleted the fix/UBE_cannot_view_or_interact_with_the_classic_block_on_jetpack_sites_new branch October 15, 2020 21:57
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marecar3 @cameronvoell @guarani