Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Issue 12404/remove status and visibility option" #12423

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Jul 10, 2020

Fixes #12404

Solution

This PR reverts the changes that were made in #12409 to disable the Status & Visibility option in the bottom sheet. This revert is taking place because we will be merging these changes into the 15.3 instead of the 15.2 release that this PR currently targets.

Testing

Ensure the Status & Visibility option as seen in the screenshot below exists within the current release.


  1. Create a new post.
  2. Click Publish.
  3. Ensure that the Status & Visibility option is visible.

  1. Create a new page.
  2. Click Publish.
  3. Ensure that the Status & Visibility option is visible.

Reviewing

Only 1 reviewer is needed but anyone can review.

Submitter Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
  • I have considered adding accessibility improvements for my changes.
  • If it's feasible, I have added unit tests.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jkmassel jkmassel merged commit 61ea3f7 into release/15.2 Jul 10, 2020
@jkmassel jkmassel deleted the revert-12409-issue-12404/remove_status_and_visibility_option branch July 10, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants