Gutenberg/allow unsupported block editor on atomic sites #12405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
marecar3
changed the base branch from
develop
to
gutenberg/release_1.32_integration
|
You can test the changes on this Pull Request by downloading the APK here. |
|
Hey @marecar3 I'm having trouble with the build. I've downloaded Version pr-12405-build-60636, which looks like the correct build, but when I log into a regular WP.com site, the bottom sheet is missing the edit options.
|
6 tasks
|
Re-tested on Galaxy S10 running Android 10 with new build 60664. (Note, I'm using the updated unsupported block sample HTML found here: wordpress-mobile/test-cases#42 since there are changes to the test cases that haven't been merged yet.) |
guarani
approved these changes
Jul 9, 2020
guarani
approved these changes
Jul 9, 2020
guarani
deleted the
gutenberg/allow-unsupported-block-editor-on-atomic-sites
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The Unsupported Block Editor feature was disabled on sites connected via Jetpack because of an issue requesting cookies from those sites without having login credentials other than WP.com credentials.
This inadvertently blocked Atomic sites as well, which are also connected via Jetpack. Atomic sites, being WP.com sites, don't have the cookie issue so this PR enables this feature on those sites.
GB-Mobile PR: wordpress-mobile/gutenberg-mobile#2476
GB PR: WordPress/gutenberg#23830
Addresses: wordpress-mobile/gutenberg-mobile#2470
To test: perform the Unsupported Block test cases 1 to 4.
PR submission checklist:
RELEASE-NOTES.txtif necessary.