Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npe in Reader #12310

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Fix npe in Reader #12310

merged 1 commit into from
Jun 29, 2020

Conversation

malinajirka
Copy link
Contributor

Fixes #12210

I decided to create this fix even though it's not ideal, since it's technically hiding the bug. However, I couldn't figure out the reason why the data are not in the database and the number of affected users started to increase.

To test:
I don't know how to reproduce the issue, so just smoketest Reader.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 15.2 milestone Jun 29, 2020
@malinajirka malinajirka requested review from zwarm and ashiagr June 29, 2020 07:40
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@ashiagr ashiagr self-assigned this Jun 29, 2020
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ashiagr ashiagr merged commit faeb87e into develop Jun 29, 2020
@ashiagr ashiagr deleted the issue/12210-fix-npe-in-reader branch June 29, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ReaderPostListViewModel] IllegalArgumentException: Parameter specified as non-null is null
2 participants