Merge 15.1 final to develop #12304
Merged
Merge 15.1 final to develop #12304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test the changes on this Pull Request by downloading the APK here. |
loremattei
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
LGTM!
I'll take care of updating GlotPress (though if you already made a suggestion, translators should fix them).
I don't know what the process for getting write rights on the .org GlotPress is. I just inherited the rights when the previous maintainer left the company.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the usual final commits, 2e69335 replaces the - character with en-dash similar to #11592. @loremattei as I mentioned in #12189, I tried to update the original string in GlotPress but it looks like I don't have proper permissions and all I can do is suggest the change. Could you please update GlotPress to reflect these changes? If you can help me with getting the right permissions, I am happy to take care of these issues myself.