Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Adjust the fetching of custom colors #12289

Merged
merged 5 commits into from
Jun 29, 2020
Merged

[Gutenberg] Adjust the fetching of custom colors #12289

merged 5 commits into from
Jun 29, 2020

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jun 25, 2020 •
edited
Loading

Fixes: wordpress-mobile/gutenberg-mobile#2432
Flux-C PR: wordpress-mobile/WordPress-FluxC-Android#1620

To Test:

  1. Select a theme on your self-hosted site with custom gradients (such as twentytwenty-copy.zip)
  2. In the Android app open the block editor
  3. EXPECT: to see the Custom Gradients
  4. Change your site's theme to a theme without custom gradients (such as Twenty-Twenty)
  5. Open the block editor again
  6. EXPECT: to see the Default Gradients

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added this to the 15.2 milestone Jun 25, 2020
@chipsnyder chipsnyder requested a review from mkevins June 25, 2020 23:33
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 25, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@chipsnyder chipsnyder mentioned this pull request Jun 25, 2020
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 25, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

mkevins
mkevins approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via: wordpress-mobile/WordPress-FluxC-Android#1620

@chipsnyder chipsnyder merged commit fd10bf2 into develop Jun 29, 2020
@chipsnyder chipsnyder deleted the rnmobile/2432-defaultColors branch June 29, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

Assignees
No one assigned
Labels
[Type] Bug
Projects
None yet
Milestone
15.2
Development

Successfully merging this pull request may close these issues.

Default Gradients are lost on theme changes for self hosted sites.
2 participants
@chipsnyder @mkevins