-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set user-agent to Gutenberg WebView #12249
Set user-agent to Gutenberg WebView #12249
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
I spend some time trying to setup GB environment and I keep getting various errors, I don't have much context about what's going wrong, so It's hard to fix them. I'm going unassign myself, so maybe someone with working environment cant take a look at this PR 🙇 |
…logging-in # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java # libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/GutenbergEditorFragment.java
Hey @khaykov, could you give it another chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to make it work! Thanks for the fix @marecar3 , it works as expected. I was not able to reproduce the issue by removing setUserAgentString
. Is there something else I can do to confirm it?
This request was failing after login affecting Gutenberg Web View for Unsupported blocks.
Fixes parts of wordpress-mobile/gutenberg-mobile#2358
Example of user-agent that we set to user-agent:
user-agent: Mozilla/5.0 (Linux; Android 10; Pixel 3 Build/QQ2A.200501.001.B2; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/83.0.4103.106 Mobile Safari/537.36 wp-android/alpha-230
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.cc @aerych