Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 15.1-rc-2 to master #12233

Merged
merged 19 commits into from
Jun 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8792f5e
Whitespace changes in FastFile
oguzkocer Jun 9, 2020
368dee5
Update .configure to copy google-upload-credentials.json
oguzkocer Jun 12, 2020
62e86cb
Adds automated play store uploads to Fastlane
oguzkocer Jun 12, 2020
2a6c319
Fixes upload_build_to_play_store lane to use version directly
oguzkocer Jun 12, 2020
9fb9e07
Update FluxC version to 1.6.14.1
oguzkocer Jun 16, 2020
d352ba5
Merge remote-tracking branch 'origin/release/15.1' into add/automated…
oguzkocer Jun 18, 2020
3590b40
Fixes the track option for uploading builds
oguzkocer Jun 18, 2020
6d8c8e6
Update release notes for 15.1 after editorial
oguzkocer Jun 18, 2020
cf19d4b
Update metadata strings
oguzkocer Jun 18, 2020
ebc6fe8
Bump version number
oguzkocer Jun 18, 2020
81a4c42
Merge remote-tracking branch 'origin/release/15.1' into add/automated…
oguzkocer Jun 18, 2020
28a4852
build_pre_releases lane renamed as build_and_upload_pre_releases
oguzkocer Jun 18, 2020
f2795a2
Update .configure with the latest hash
oguzkocer Jun 18, 2020
54301e3
Fix build_alpha & build_beta example comments
oguzkocer Jun 18, 2020
e28541e
Fix NPE change && to ||
zwarm Jun 18, 2020
9feff26
Merge pull request #12217 from wordpress-mobile/add/automated-play-st…
oguzkocer Jun 18, 2020
b4ee35d
Merge pull request #12221 from wordpress-mobile/fix/12022-npe
oguzkocer Jun 18, 2020
c00d840
Fixed issue where rotating device would cause new tags not to persist.
jd-alexander Jun 18, 2020
eb1ab98
Merge pull request #12225 from wordpress-mobile/issue-12224/tags_edit…
oguzkocer Jun 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .configure
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"project_name": "WordPress-Android",
"branch": "master",
"pinned_hash": "62249ca6e914a98dcee0bb715fab1d24053ce65b",
"pinned_hash": "e0baad79188676d7447d5b8eca1cb27dd949bf4a",
"files_to_copy": [
{
"file": "android/WPAndroid/gradle.properties",
Expand All @@ -27,6 +27,11 @@
"file": "android/automattic.jks",
"destination": "WordPress/release.jks",
"encrypt": false
},
{
"file": "android/WPAndroid/google-upload-credentials.json",
"destination": "google-upload-credentials.json",
"encrypt": true
}
],
"file_dependencies": [
Expand Down
Binary file not shown.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,15 @@ WordPress/src/main/res/values/com_crashlytics_export_strings.xml
# Google services configuration
google-services.json

# Fastlane
# Fastlane
fastlane/.env*
fastlane/report.xml
fastlane/README.md
fastlane/metadata/android/screenshots.html
fastlane/metadata/android/*/images/
fastlane/screenshots_orig
default.profraw
google-upload-credentials.json

# Bundler
/.bundle
Expand Down
8 changes: 4 additions & 4 deletions WordPress/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ android {
if (project.hasProperty("versionName")) {
versionName project.property("versionName")
} else {
versionName "alpha-229"
versionName "alpha-230"
}
versionCode 882
versionCode 884
minSdkVersion rootProject.minSdkVersion
targetSdkVersion rootProject.targetSdkVersion

Expand Down Expand Up @@ -85,9 +85,9 @@ android {
dimension "buildType"
// Only set the release version if one isn't provided
if (!project.hasProperty("versionName")) {
versionName "15.1-rc-1"
versionName "15.1-rc-2"
}
versionCode 881
versionCode 883
buildConfigField "boolean", "ME_ACTIVITY_AVAILABLE", "false"
buildConfigField "boolean", "TENOR_AVAILABLE", "false"
buildConfigField "boolean", "READER_IMPROVEMENTS_PHASE_2", "false"
Expand Down
24 changes: 13 additions & 11 deletions WordPress/metadata/PlayStoreStrings.po
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ msgstr ""
"Project-Id-Version: Release Notes & Play Store Descriptions\n"

#. translators: Release notes for this version to be displayed in the Play Store. Limit to 500 characters including spaces and commas!
msgctxt "release_note_151"
msgid ""
"15.1:\n"
"Block editor improvements: Scheduling, tag, and visibility settings pop up in the post editor and post list when you tap Publish — tweak them and tap “Publish Now” to complete publication. Pressing enter after adding a caption in Image, Video, Gallery, Quote, and Pullquote blocks automatically adds a new block.\n"
"\n"
"Fixes: Video thumbnails, settings, and preview display properly in the Media section on private sites. Notifications and Install Jetpack tabs no longer display on top of one another.\n"
msgstr ""

msgctxt "release_note_150"
msgid ""
"15.0:\n"
Expand All @@ -20,15 +28,15 @@ msgid ""
"Other updates: Added homepage settings to pages list and to site settings. Improved Reader UI.\n"
msgstr ""

msgctxt "release_note_149"
#. translators: A shorter version of the Release notes to be displayed in the Play Store. Limit to 500 characters including spaces and commas!
msgctxt "release_note_short_151"
msgid ""
"14.9:\n"
"<b>Block editor enhancements:</b> New Pullquote block, Button block color options, updated page templates.\n"
"15.1:\n"
"Improvements: Scheduling, tag, and visibility panel pops up in editor and post list pre-publication. Pressing enter after adding captions in Image, Video, Gallery, Quote, and Pullquote blocks adds a new block.\n"
"\n"
"<b>Block editor fixes:</b> Free Photo Library bug that inserted single images even if several were selected, preview failure when switching to the classic editor. Removed non-functional Subscription Button from Blog template.\n"
"Fixes: Video thumbnails, settings, and preview display properly on private sites. Notifications and Install Jetpack tabs no longer overlay.\n"
msgstr ""

#. translators: A shorter version of the Release notes to be displayed in the Play Store. Limit to 500 characters including spaces and commas!
msgctxt "release_note_short_150"
msgid ""
"15.0:\n"
Expand All @@ -37,12 +45,6 @@ msgid ""
"Other updates: Added homepage settings to pages list and to site settings.\n"
msgstr ""

msgctxt "release_note_short_149"
msgid ""
"14.9:\n"
"<b>Block editor enhancements:</b> New Pullquote block, Button block color options, updated page templates.\n"
msgstr ""

#. translators: Release notes for this version to be displayed in the Play Store. Limit to 500 characters including spaces and commas!
msgctxt "sample_post_content"
msgid "The best moment of any trip, for me, is when I first step foot off the plane. The whole of the trip is in front me, ripe with possibility."
Expand Down
7 changes: 3 additions & 4 deletions WordPress/metadata/release_notes.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
Block editor additions: New Verse block. Support for overlay colors in Cover block. Enter/exit animation for the Floating Toolbar. Tooltip for page template selection buttons.
Block editor updates: “Trash block” in a menu reachable from the block toolbar.
Block editor fixes: Text block merging issue, button alignment in page templates, string inconsistencies.
Other updates: Added homepage settings to pages list and to site settings. Improved Reader UI.
Block editor improvements: Scheduling, tag, and visibility settings pop up in the post editor and post list when you tap Publish — tweak them and tap “Publish Now” to complete publication. Pressing enter after adding a caption in Image, Video, Gallery, Quote, and Pullquote blocks automatically adds a new block.

Fixes: Video thumbnails, settings, and preview display properly in the Media section on private sites. Notifications and Install Jetpack tabs no longer display on top of one another.
6 changes: 3 additions & 3 deletions WordPress/metadata/release_notes_short.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Block editor additions: New Verse block. Support for overlay colors in Cover block. Enter/exit animation for Floating Toolbar. Tooltip for page template selection buttons.
Block editor updates: “Trash block” in a menu reachable from the block toolbar.
Other updates: Added homepage settings to pages list and to site settings.
Improvements: Scheduling, tag, and visibility panel pops up in editor and post list pre-publication. Pressing enter after adding captions in Image, Video, Gallery, Quote, and Pullquote blocks adds a new block.

Fixes: Video thumbnails, settings, and preview display properly on private sites. Notifications and Install Jetpack tabs no longer overlay.
Original file line number Diff line number Diff line change
Expand Up @@ -1401,7 +1401,7 @@ private void showMoreMenu(View view) {
}

private void trashComment() {
if (!isAdded() && mComment == null) {
if (!isAdded() || mComment == null) {
return;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,11 @@ class PrepublishingTagsViewModel @Inject constructor(
val toolbarTitleUiState: LiveData<UiString> = _toolbarTitleUiState

fun start(editPostRepository: EditPostRepository) {
this.editPostRepository = editPostRepository

if (isStarted) return
isStarted = true

this.editPostRepository = editPostRepository
setToolbarTitleUiState()
}

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ ext {
androidxWorkVersion = "2.0.1"

daggerVersion = '2.22.1'
fluxCVersion = '1.6.14'
fluxCVersion = '1.6.14.1'

appCompatVersion = '1.0.2'
constraintLayoutVersion = '1.1.3'
Expand Down
Loading