Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepublishing Nudges : Fixed issue where rotating device would cause new tag to not persist #12225

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Jun 18, 2020

Fixes #12224

Solution

The EditPostRepository needs to be set beforeisStarted is called because when rotation takes place the ViewModel instance is retained thus it's already started. Nonetheless, the EditPostRepository reference needs to be set to the ViewModel

Testing

  1. Open any post for editing.
  2. Add some tags.
  3. Rotate the device.
  4. Observe that previously entered tags remain visible.
  5. Add a new tag to the list (after the device was rotated).
  6. Tap the left arrow to go back or X to close the tag editor.
  7. Observe that all the tags that have been added exist.

Reviewing

Only 1 reviewer is needed but anyone can review.

Submitter Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
  • I have considered adding accessibility improvements for my changes.
  • If it's feasible, I have added unit tests.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 18, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 18, 2020

You can test the changes on this Pull Request by downloading the APK here.

@jd-alexander jd-alexander requested a review from oguzkocer June 18, 2020 23:52
@jd-alexander jd-alexander changed the base branch from develop to release/15.1 June 18, 2020 23:53
@oguzkocer oguzkocer force-pushed the issue-12224/tags_editpostrepository branch from 25d0c62 to c00d840 Compare June 18, 2020 23:57
@oguzkocer oguzkocer merged commit eb1ab98 into release/15.1 Jun 19, 2020
@oguzkocer oguzkocer deleted the issue-12224/tags_editpostrepository branch June 19, 2020 00:21
This was referenced Jun 19, 2020
@malinajirka
Copy link
Contributor

Thanks for the review! Btw it seems the milestone is set to 15.2, but the target branch is 15.1. Should we update the milestone for consistency?

@oguzkocer oguzkocer modified the milestones: 15.2, 15.1 ❄️ Jun 19, 2020
@jd-alexander jd-alexander modified the milestones: 15.1 ❄️, 15.2 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants