Merge 15.1 code freeze to develop #12204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
chipsnyder
reviewed
Jun 16, 2020
| @@ -124,7 +124,7 @@ ext { | |||
| androidxWorkVersion = "2.0.1" | |||
|
|
|||
| daggerVersion = '2.22.1' | |||
| fluxCVersion = '1.6.13' | |||
| fluxCVersion = '1.6.14' | |||
There was a problem hiding this comment.
FYI there was an error in the WellSQL for 1.6.14 that was just discovered. Corrected that here:
wordpress-mobile/WordPress-FluxC-Android#1606
1.6.14 is only needed for #12041 though, so we can either leave this as 1.6.13 or get the FluxC fix in either is fine IMO.
jkmassel
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FluxC version is updated to
1.6.14which points to the latest commit at the time of this PR creation. cc @chipsnyder @planarvoid @khaykov