Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/12028 discover ui state #12202

Merged
merged 6 commits into from
Jun 16, 2020
Merged

Issue/12028 discover ui state #12202

merged 6 commits into from
Jun 16, 2020

Conversation

malinajirka
Copy link
Contributor

Partially fixes #12028

Adds Loading and Content UIState to discover VM. Also starts loading data from the post repository and maps them to the UIState.

To test:
No user-facing changes. Code review + working CI should be enough.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added [Type] Task New Reader Android Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. labels Jun 15, 2020
@malinajirka malinajirka requested review from zwarm and ashiagr June 15, 2020 14:28
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 15, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 15, 2020

You can test the changes on this Pull Request by downloading the APK here.

@malinajirka malinajirka mentioned this pull request Jun 16, 2020
3 tasks
@ashiagr ashiagr self-assigned this Jun 16, 2020
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍.

@ashiagr ashiagr merged commit b976393 into develop Jun 16, 2020
@malinajirka malinajirka added this to the 15.2 milestone Jun 25, 2020
@malinajirka malinajirka removed the Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. label Jun 25, 2020
@jkmassel jkmassel deleted the issue/12028-discover-ui-state branch October 17, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader Improvements: New Discover Main Issue
2 participants