Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to gb-mobile hash with updated typographic rhythm #12156

Closed
wants to merge 2 commits into from

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Jun 10, 2020

** Draft PR for apk building purposes. Will not merge. **

This PR points to gutenberg-mobile's wordpress-mobile/gutenberg-mobile#2369 to test out the typographic rhythm changes.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 10, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 10, 2020

You can test the changes on this Pull Request by downloading the APK here.

@hypest
Copy link
Contributor Author

hypest commented Sep 18, 2020

Closing until we go back working on wordpress-mobile/gutenberg-mobile#550.

@hypest hypest closed this Sep 18, 2020
@jkmassel jkmassel deleted the gutenberg/try-spacious-typographic-rhythm branch October 17, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant