Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert me fragment to kotlin #12152

Merged
merged 20 commits into from
Jun 15, 2020
Merged

Conversation

planarvoid
Copy link
Contributor

In order to remove view memory leaks and usage of an inner async task I've converted the MeFragment to kotlin. There are mostly no functionality changes. The only change is replacing the async task with a coroutine in a view model.

To test:

  • Go to the Me screen and stress test it
  • Try log out of WP.com
  • The progress dialog is shown
  • You're correctly logged out

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 10, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 10, 2020

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @planarvoid ! LGTM - feel free to merge it when you fix the lint issues.

# Conflicts:
#	WordPress/src/main/java/org/wordpress/android/modules/ViewModelModule.java
@malinajirka malinajirka merged commit 4bd5984 into develop Jun 15, 2020
@malinajirka malinajirka deleted the fix/convert-me-fragment-to-kotlin branch June 15, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants