Provide exception logger for gutenberg #11965
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
mchowning
force-pushed
the
issue_9832/span_index_exceptions
branch
3 times, most recently
from
d73cc37 to
a78f184
Compare
mchowning
force-pushed
the
issue_9832/span_index_exceptions
branch
from
a78f184 to
d11ff41
Compare
|
👋 @geriux ! Thanks for the review! 🙇 I made a few generally minor updates to this PR and the related gutenberg-mobile PR since your approval, so you may want to give these another look. |
RELEASE-NOTES.txt
Outdated
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| 14.9 | |||
| ----- | |||
| * [**] Block editor: Avoid crash when editor gets into invalid state | |||
There was a problem hiding this comment.
Since we already sent the translations for 14.9 and considering this may not be a crucial update, I'd consider removing it from the release notes or marking it as internal. We have had some issues in the past where some translations were marked as fuzzy because they were altered after submission and didn't get translated. I don't think it'll be a big issue when we are adding a completely new bullet point, but to be on the safe side, I'd suggest removing it.
We also don't have any room left in the shorter or longer versions of the release notes for this version, so we'd have to remove something else for it.
There was a problem hiding this comment.
Thanks @oguzkocer ! Does the fact that this is fixing a really prevalent crash (140k crashes for 20k users in the last 90 days) change your assessment of how we should handle this release note at all? I don't feel strongly.
There was a problem hiding this comment.
It could - in some cases. From a user's perspective, even if I saw this release note, it'd not mean that it's a big deal to me. (personal opinion) In that regard, I don't feel our users would miss a crucial information. Having said that, I only brought it up as a suggestion, if you want me to see if editorial can squeeze it in, I am happy to ask them. (they'll most likely ask some details btw)
There was a problem hiding this comment.
even if I saw this release note, it'd not mean that it's a big deal to me
That's a good point since it's not like there is a clear path to this crash that I'm able to call out in the release note. I'll go ahead and take this release note out. 👍
mchowning
changed the base branch from
release/14.9
to
gutenberg/integrate_release_1.28.1
|
It looks like we're going to have 2 fixes in 1.28.1 (maybe 3), so I created a |
|
@mchowning Could you give me a heads up when it's all merged in so I can build a new beta? We have a couple other fixes waiting for the Gutenberg fixes to be merged for a new beta :) |
Addresses #9832
See the related gutenberg-mobile PR for more details and testing steps: wordpress-mobile/gutenberg-mobile#2279
PR submission checklist:
RELEASE-NOTES.txtif necessary.