Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on opening external url #11873

Merged
merged 1 commit into from
May 12, 2020
Merged

Fix crash on opening external url #11873

merged 1 commit into from
May 12, 2020

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented May 8, 2020

Fixes #11820

To test

  • Create a new post in the mobile app on a device with Android Lollipop OS.
  • Add a link to the post.
  • Preview the post.
  • Click the link.
  • Link should open properly without any crash.
Before After
link_not_ok link_ok_final

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr added this to the 14.9 milestone May 8, 2020
@ashiagr ashiagr requested a review from planarvoid May 8, 2020 13:53
@ashiagr ashiagr self-assigned this May 8, 2020
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

planarvoid
planarvoid approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@planarvoid planarvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, it works well 👍

@planarvoid planarvoid merged commit 47cb966 into develop May 12, 2020
@planarvoid planarvoid deleted the issue/11820-fix-crash-open-external-link branch May 12, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planarvoid planarvoid planarvoid approved these changes

Assignees

@ashiagr ashiagr

Labels
[Type] Bug
Projects
None yet
Milestone
14.9
2 participants
@ashiagr @planarvoid