Gutenberg/embedded build no jitpack against release #11865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally, passing down a "jitpack" flag to emulate the nested gutenberg-mobile build, which behind the scenes uses Node and Yarn to install the needed gutenberg-mobile RN dependencies to build.
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
On CircleCI, the JS bundle is build by a dedicated job to avoid out of memory issues when doing it embedded in the gradle build.
To try and avoid the out of memory issue (exit code 137) that seems to be happening.
hypest
force-pushed
the
gutenberg/embedded-build-no-jitpack-against-release
branch
from
7259847 to
610239f
Compare
The gb-mobile JS bundle has already been built and shared as via a CircleCI attached workspace so, no need for the nested submodules that only contribute JS code anyway.
3 tasks
hypest
deleted the
gutenberg/embedded-build-no-jitpack-against-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to test #11833 targeting the frozen release v14.8. If CI goes well here, will re-target the original PR. ✅
Now, this PR will serve as a testing ground for cleaning up the solution.
Additional work done on this PR:
parallelflag for gradle