Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/11760 reader empty view ui #11812

Merged
merged 6 commits into from
May 12, 2020
Merged

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented May 4, 2020

Fixes #11760
This PR changes the Reader UI for empty views on the Following tab and the Followed Site tabs. The copy has been updated to reflect the requested design changes.

Screenshot_20200504-095759_WordPress Beta
Screenshot_20200504-095855_WordPress Beta
Screenshot_20200504-095916_WordPress Beta
Screenshot_20200504-095922_WordPress Beta

To Test
(A) Light mode

  • Log into an account that is not following any sites
  • Set app to light mode
  • Navigate to the reader tab
  • Tab on the Following tab
  • The updated empty view should be visible
  • Tap on the Manage Tags & Sites Settings Cog
  • Tap on the Followed Sites tab
  • The updated empty view should be visible

(B) Set app to dark mode and repeat above steps

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 4, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@zwarm
Copy link
Contributor Author

zwarm commented May 4, 2020

@mbshakti - if you have time, can you take a peek and see if it's what you expected. Thanks.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 4, 2020

You can test the changes on this Pull Request by downloading the APK here.

@zwarm zwarm added the [Status] Needs Design Review A designer needs to sign off on the implemented design. label May 4, 2020
@malinajirka malinajirka self-assigned this May 5, 2020
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zwarm! I've left a couple of in-code comments. Let me know what you think ;)

@zwarm zwarm added this to the 14.9 milestone May 6, 2020
@mbshakti
Copy link

We discussed this briefly on slack, but there seems to be a weird pixelated edge on the illustration. I increased the stroke width on it and exported a new illustration, hopefully this helps!

also per @malinajirka's comment, I've updated the colors in the illustration to make sure they're from our palette. Here's the color specifications. Thanks a lot @zwarm

@zwarm
Copy link
Contributor Author

zwarm commented May 11, 2020

Updated screenshots with vector drawables adjusted.

Light Dark

@mbshakti
Copy link

Thanks so much @zwarm!

@malinajirka
Copy link
Contributor

Thanks @zwarm! I've tested the app and it looks awesome;). The code looks good. I think this PR is ready to be merged as soon as we receive a reply for the question regarding the colors - related post paqN3M-1N-p2. I personally like your approach and it's an approach I used in other apps (before dark mode).

@zwarm zwarm removed the [Status] Needs Design Review A designer needs to sign off on the implemented design. label May 12, 2020
@zwarm zwarm removed request for ashiagr and jd-alexander May 12, 2020 12:03
@zwarm zwarm merged commit a9d79fd into develop May 12, 2020
@zwarm zwarm deleted the issue/11760-reader-empty-view-ui branch May 12, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI of the empty view on the following tab
3 participants