-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/11760 reader empty view ui #11812
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
@mbshakti - if you have time, can you take a peek and see if it's what you expected. Thanks. |
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zwarm! I've left a couple of in-code comments. Let me know what you think ;)
WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderBlogFragment.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/res/drawable-night/img_illustration_empty_results_162dp.xml
Outdated
Show resolved
Hide resolved
We discussed this briefly on slack, but there seems to be a weird pixelated edge on the illustration. I increased the stroke width on it and exported a new illustration, hopefully this helps! also per @malinajirka's comment, I've updated the colors in the illustration to make sure they're from our palette. Here's the color specifications. Thanks a lot @zwarm |
Thanks so much @zwarm! |
Thanks @zwarm! I've tested the app and it looks awesome;). The code looks good. I think this PR is ready to be merged as soon as we receive a reply for the question regarding the colors - related post paqN3M-1N-p2. I personally like your approach and it's an approach I used in other apps (before dark mode). |
Fixes #11760
This PR changes the Reader UI for empty views on the Following tab and the Followed Site tabs. The copy has been updated to reflect the requested design changes.
To Test
(A) Light mode
(B) Set app to dark mode and repeat above steps
PR submission checklist:
RELEASE-NOTES.txt
if necessary.