-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update media insertion to send caption information." #11706
Revert "Update media insertion to send caption information." #11706
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
You can test the changes on this Pull Request by downloading the APK here. |
I'm a bit concerned that this will cause us to lose the original changes on the We could add both (1) a commit reverting the changes and (2) a commit reverting that revert to I bet we've dealt with this kind of situation more than a few times in the past and someone like @oguzkocer may know of a much better solution we've used in the past to make sure we don't lose the changes when the release gets merged back to |
I see the concern here. One way to protect against this might be to revert on |
@mchowning I use merge branches when I merge changes from release branches to Let me know if you have any questions! |
@cameronvoell @mchowning @maxme Can we review this PR and merge it in? I think there might be some miscommunication here, were you maybe expecting a 👍 from me, because I am waiting for the merge (or at least an approval) of the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and app is working well. Hashes are back to the 1.26 tagged versions for gutenberg and gutenberg-mobile. 👍
Reverts #11670
We are reverting the change so that the 14.7 release branch has the correct gutenberg-mobile reference corresponding to the Gutenberg-Mobile v1.26.0 Editor release
Proper gb-mobile ref should be 315a213f1ae70e670213d2369933d2725f4a72f4
https://github.com/wordpress-mobile/gutenberg-mobile/commits/master