@-mention Activity for Gutenberg #11693

mchowning · 2020-04-17T22:11:50Z

Related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2163

Adds @-mention support in the Gutenberg editor. Also updates the @-mention support throughout WPAndroid to show the popup immediately after the @-symbol is shown instead of waiting until an "@" plus a single letter is shown. This change brings Android in line with the behavior on iOS.

Slow Initial Loading of Suggestions

The first time the suggestions are loaded for a site (which is done the first time a SuggestionAutocompleteTextView is displayed, the suggestions are very slow to load. In my testing, it would take 20-30 seconds before the suggestions would be available to the user.

One cause of this is the slowness of the API call for sites with many users. In my tests the api call for a site with 1500+ users took 3 to 6 seconds. A site with only a single user returned in well under a second.

The larger problem, however, is that inserting those suggestions into the database is taking >15 seconds. I have a separate PR to address that delay, but that fix is not included in this PR, so expect a significant delay the first time the suggestions are loaded for a particular site.

Testing

Gutenberg

Inserting mentions:

Edit a post using Gutenberg
Open any RichText-based block.
Tap the @ button on the far right of the format toolbar
Either
Tap on one of the mentions suggested by the UI or
Enter enough text to filter down to a single suggestion and then press the done button on the keyboard
Observe the appropriate mention is inserted into the block

Does not insert with keyboard done button if there is anything but a single suggestion

Edit a post using Gutenberg
Open any RichText-based block.
Tap the @ button on the far right of the format toolbar
Enter text to filter to either 0 or >2 mentions (so not 1)
Tap the keyboard's done button
Observe a toast message advising that the user has not entered a valid mention.

WPAndroid

Add or respond to a comment using the app
Observe that the @-mention popup occurs after typing the @ symbol instead of needing @ + a letter to reveal the suggestions.

PR submission checklist:

I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

peril-wordpress-mobile · 2020-04-17T22:11:56Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2020-04-17T22:21:11Z

You can test the changes on this Pull Request by downloading the APK here.

oguzkocer · 2020-04-20T20:30:02Z

Hi there! 14.7 is being frozen, so this PR is being bumped to 14.8. If these changes have to be shipped with 14.7, please target release/14.7 and cc me in the PR so I can cut a new beta release. Also if you can keep the release dates in mind and bump the PRs & issues you are working on before the code freeze date, we'd really appreciate it.

P.S: I am still working on the messaging for these bumps, so please let me know if you have any questions/concerns/feedback.

…r "@"

Updated style no longer requires fitsSystemWindow, which allows the code to be simplified.

Avoids an issue where the empty view appears when it shouldn't at times. For example if you press the background when there is a single suggestion and don't lift your finger, the suggestion disappears, but the activity doesn't close until you left your finger, so the empty view becomes visible as long as you hold your finger down.

oguzkocer · 2020-05-04T10:46:24Z

Hi there! 14.8 is being frozen, so this PR is being bumped to 14.9. If these changes have to be shipped with 14.8, please target release/14.7 and cc me in the PR so I can cut a new beta release. Also if you can keep the release dates in mind and bump the PRs & issues you are working on before the code freeze date, we'd really appreciate it.

cameronvoell

I tested the main cases from the description and they look good.

A super minor issue is that if you rotate while the @ menu is open, and then select an option, I do not see it get added. If you then try a second time it works. Since it doesn't cause any bad state, I don't see it as a blocker, maybe something to look at in future improvements.

I saw you have a PR up for enabling a space after the @ mention. I'll take a look at that next. Nice job on this, especially the nice Java 8 method reference refactor 🎉 .

(edit - minor issue that I think is not a blocker, video on gutenberg PR WordPress/gutenberg#21651 (review))

cameronvoell · 2020-05-07T00:57:20Z

...itor/WordPressEditor/src/main/java/org/wordpress/android/editor/GutenbergEditorFragment.java

+                mEditorFragmentListener::onAuthHeaderRequested,
+                mEditorFragmentListener::onPerformFetch,
+                mEditorImagePreviewListener::onImagePreviewRequested,
+                mEditorEditMediaListener::onMediaEditorRequested,


Love how concise this is with Java 8 double colon method reference 👍

cameronvoell · 2020-05-07T01:08:26Z

RELEASE-NOTES.txt

@@ -16,6 +16,8 @@
 * Added user Gravatar to the Me menu in My Site.
 * Updated site details screen title to "My site", to avoid duplicating the title of the current site which is displayed in the screen's header area. 

+* @-mention suggestions are now presented immediately after typing "@"


Maybe change from "typing" to "entering" or "pressing" "@" since the ability to type "@" on the keyboard is a design request that is not yet implemented. WDYT?

Good catch, I think you're right! I actually need to remove this entirely for now though because we're going to keep this under a dev flag for the time being.

cameronvoell · 2020-05-07T01:24:28Z

WordPress/src/main/java/org/wordpress/android/ui/suggestion/adapters/SuggestionAdapter.java

+                                         .startsWith(lowerCaseConstraint)
+                            || suggestion.getDisplayName().toLowerCase(Locale.getDefault())
+                                         .contains(" " + lowerCaseConstraint);
+                    if (suggestionMatchesConstraint) {


Almost suggested a unit test here, but then saw it was really just three intuitive cases, and I tested to make sure they all work fine. Looks good

# Conflicts: # libs/gutenberg-mobile

mchowning requested review from hypest, cameronvoell and marecar3 April 17, 2020 22:11

mchowning self-assigned this Apr 17, 2020

mchowning mentioned this pull request Apr 20, 2020

Speed up suggestion insertion by using a single transaction #11702

Merged

3 tasks

mchowning added the gutenberg-mobile label Apr 20, 2020

mchowning added this to the 14.7 milestone Apr 20, 2020

mchowning force-pushed the gutenberg/issue_331/mention_support branch from ecef710 to dc61f32 Compare April 20, 2020 16:11

mchowning mentioned this pull request Apr 20, 2020

Add @-mention support wordpress-mobile/gutenberg-mobile#2163

Merged

2 tasks

mchowning requested a review from iamthomasbishop April 20, 2020 17:19

mchowning marked this pull request as ready for review April 20, 2020 17:19

mchowning force-pushed the gutenberg/issue_331/mention_support branch from dc61f32 to 85f416b Compare April 20, 2020 18:35

mchowning changed the base branch from gutenberg/after_1.26.0 to develop April 20, 2020 19:58

oguzkocer modified the milestones: 14.7, 14.8 Apr 20, 2020

mchowning marked this pull request as draft April 24, 2020 20:21

mchowning added 11 commits April 27, 2020 13:26

Initial implementation of User picking Activity for Gutenberg

8bbb383

Always display all available suggestions in SuggestUsersActivity

cb5ea3c

Update SuggestionAutoCompleteText to always complete immediately afte…

c43112f

…r "@"

Cleanup SuggestUsersActivity

4f259be

Updated style no longer requires fitsSystemWindow, which allows the code to be simplified.

Add Enter key handling for SuggestUsersActivity

dadd4af

Update Release Notes

956611e

Don't reset suggestion text on rotation

1fb5e77

Handle when there are no users to suggest

3659f40

Update mention text field height to match Gutenberg

52553bc

Pass mentions capability back to RN

be7b789

Deleting when only @ is shown closes SuggestUsersActivity

7727a02

mchowning added 5 commits April 28, 2020 08:55

Prevent dismissing suggestions when toolbar is tapped

eb30206

Keep SuggestsionAdapter count always up-to-date

0bb3260

Only keep dropdown open on touch if there are suggestions

e4a69e9

Update gutenberg-mobile ref

a412607

Refresh suggestions list immediately when new data arrives

cb035c5

mchowning force-pushed the gutenberg/issue_331/mention_support branch from 3baf0d4 to cb035c5 Compare April 28, 2020 16:55

Fix divider in Suggestion Activity

3a791c1

mchowning force-pushed the gutenberg/issue_331/mention_support branch from fcf39fc to 077881e Compare April 29, 2020 13:11

mchowning marked this pull request as ready for review April 29, 2020 13:12

mchowning force-pushed the gutenberg/issue_331/mention_support branch from 077881e to 4abaf71 Compare April 29, 2020 13:22

Remove paddingHorizontal

bf93139

hypest removed their request for review April 30, 2020 08:22

Remove UI glitches during exit transition from SuggestUsersActivity

deb0813

oguzkocer modified the milestones: 14.8, 14.9 May 4, 2020

cameronvoell approved these changes May 7, 2020

View reviewed changes

mchowning added 2 commits May 8, 2020 08:06

Update RELEASE-NOTES.txt

9a28a54

Update RELEASE-NOTES.txt

dfe5550

mchowning modified the milestones: 14.9, 15.0 May 11, 2020

Merge branch 'develop' into gutenberg/issue_331/mention_support

77b3b8a

# Conflicts: # libs/gutenberg-mobile

SergioEstevao merged commit 5ed5d7f into develop May 20, 2020

SergioEstevao deleted the gutenberg/issue_331/mention_support branch May 20, 2020 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@-mention Activity for Gutenberg #11693

@-mention Activity for Gutenberg #11693

mchowning commented Apr 17, 2020 •

edited

Loading

peril-wordpress-mobile bot commented Apr 17, 2020 •

edited

Loading

peril-wordpress-mobile bot commented Apr 17, 2020 •

edited

Loading

oguzkocer commented Apr 20, 2020

oguzkocer commented May 4, 2020

cameronvoell left a comment •

edited

Loading

cameronvoell May 7, 2020

cameronvoell May 7, 2020 •

edited

Loading

mchowning May 8, 2020

cameronvoell May 7, 2020

@-mention Activity for Gutenberg #11693

@-mention Activity for Gutenberg #11693

Conversation

mchowning commented Apr 17, 2020 • edited Loading

Slow Initial Loading of Suggestions

Testing

Gutenberg

WPAndroid

peril-wordpress-mobile bot commented Apr 17, 2020 • edited Loading

peril-wordpress-mobile bot commented Apr 17, 2020 • edited Loading

oguzkocer commented Apr 20, 2020

oguzkocer commented May 4, 2020

cameronvoell left a comment • edited Loading

Choose a reason for hiding this comment

cameronvoell May 7, 2020

Choose a reason for hiding this comment

cameronvoell May 7, 2020 • edited Loading

Choose a reason for hiding this comment

mchowning May 8, 2020

Choose a reason for hiding this comment

cameronvoell May 7, 2020

Choose a reason for hiding this comment

mchowning commented Apr 17, 2020 •

edited

Loading

peril-wordpress-mobile bot commented Apr 17, 2020 •

edited

Loading

peril-wordpress-mobile bot commented Apr 17, 2020 •

edited

Loading

cameronvoell left a comment •

edited

Loading

cameronvoell May 7, 2020 •

edited

Loading