-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mobile Gutenberg localization to code freeze #11642
Add mobile Gutenberg localization to code freeze #11642
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
@@ -67,7 +67,9 @@ ENV["HAS_ALPHA_VERSION"]="true" | |||
setbranchprotection(repository:GHHELPER_REPO, branch: "release/#{new_version}") | |||
setfrozentag(repository:GHHELPER_REPO, milestone: new_version) | |||
|
|||
localize_gutenberg(skip_module_update: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note to say that's great we're calling gutenberg_dep_check()
before that, that should ensure the bundle, and bundled strings are up to date.
fastlane/Fastfile
Outdated
if (options[:auto_commit]) then | ||
sh("cd .. && git add #{main_strings_path}") | ||
sh("git commit -m 'Update strings for translation'") | ||
sh("git push") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do git push origin HEAD
here? Just to make sure the local git config doesn't interfere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Thank you for catching this @maxme!
It seems it's hard for me to get rid of this old habit! I'm sorry for having missed it again!
This is now updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you Lorenzo!!
This PR adds a step in the
code_freeze
lane to import strings from the Gutenberg submodule into the mainstrings.xml
.As a first step, the script will stop and ask for a manual commit if any change to the main
strings.xml
is done (the script will modal-wait on the current terminal, but the changes can be reviewed and committed in another terminal).We can automate this step when we are confident that everything works as expected.
To test:
bundle install
.bundle exec fastlane localize_gutenberg
(it's the same sub-lane called during the code freeze).PR submission checklist:
RELEASE-NOTES.txt
if necessary.