Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post & Page List : Changed auto upload text from cancel to cancel upload #11636

Merged
merged 3 commits into from
Apr 13, 2020

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Apr 10, 2020

Fixes #11515

Solution

Updates the Cancel action on the Page & Post list item to Cancel upload.

Testing

  1. Turn on airplane mode.
  2. Create a post or page and publish it.
  3. An auto-upload label is displayed on the list item (eg. "We'll publish this post/page when your device is back online").
  4. You will see that Cancel upload is shown on both the Page/Post List list item option menu.
Page List (Compact) Post List (Compat) Post List (Normal)

Reviewing

Only 1 reviewer is needed but anyone can review.

Submitter Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
  • I have considered adding accessibility improvements for my changes.
  • If it's feasible, I have added unit tests.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 10, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 10, 2020

You can test the changes on this Pull Request by downloading the APK here.

@jd-alexander jd-alexander added this to the 14.7 milestone Apr 10, 2020
@jd-alexander jd-alexander requested a review from ashiagr April 10, 2020 16:42
@jd-alexander jd-alexander marked this pull request as ready for review April 10, 2020 16:43
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified "Cancel upload" is displayed as described, 🚢:)

@ashiagr ashiagr merged commit 447f949 into develop Apr 13, 2020
@ashiagr ashiagr deleted the issue-11515/post_page_rename_cancel_action branch April 13, 2020 05:50
@malinajirka
Copy link
Contributor

malinajirka commented Apr 13, 2020

@jd-alexander Thanks for working on this task! ;) However, AFAIU we were supposed to change the title just in the expanded view as per the description of the issue The goal of this task is to rename the "Cancel" action in the collapsed view on Post List and regular view on Page List (we want to keep "cancel" on the expanded view on post list).. The action in the expanded view has the same color as the label so it doesn't need more explicit label and we might want to keep it as short as possible. Wdyt?

@jd-alexander
Copy link
Contributor Author

jd-alexander commented Apr 13, 2020

Thanks for pointing that out @malinajirka. I will address that and send in another PR to correct it. Thanks 🙏

Also thanks for the review @ashiagr 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post+Page list: Rename Cancel action in collapsed view
3 participants