Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leak canary #11618

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Remove leak canary #11618

merged 1 commit into from
Apr 8, 2020

Conversation

planarvoid
Copy link
Contributor

Based on the feedback I'm removing leak canary for now and we'll keep it for the hackweek project.

To test:

  • There is nothing to test here

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@planarvoid planarvoid added this to the 14.7 milestone Apr 8, 2020
@planarvoid planarvoid self-assigned this Apr 8, 2020
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

oguzkocer
oguzkocer approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@oguzkocer oguzkocer merged commit 99cc1d9 into develop Apr 8, 2020
@oguzkocer oguzkocer deleted the fix/remove_leak_canary branch April 8, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzkocer oguzkocer oguzkocer approved these changes

@jd-alexander jd-alexander Awaiting requested review from jd-alexander

Assignees

@planarvoid planarvoid

Labels
[Type] Enhancement
Projects
None yet
Milestone
14.7
Development

Successfully merging this pull request may close these issues.
2 participants
@planarvoid @oguzkocer