-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Me gravatar menu accessibility #11613
Conversation
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the long-press and its working fine for me. Just noting that on my device i get a different UI if I long press on the FAB, compared to long press on the me menu link. The version on the 'me' icon is consistent with the UI I'm seeing for long press on other nav bar icons though, so I assume its the correct style there.
@osullivanchris while working on this PR I was thinking if it could make sense to change the alignment of the Me Menu; currently I did not change things in this PR respect to what we had here but was looking into making the me menu area wider (64dp see image below) so that it aligns on a 16dp end instead of 8dp. I think 48dp is the material design standard menu width tbh but right/end alignment (especially looking to the main FAB at the bottom) looks a bit strange maybe; let me know if there can be some better related guidelines, thanks 😊
This looks much better. Thanks for thinking about this / spotting it. You're definitely right, it looks better now. In my mocks I had 16 too but maybe I never specified it.
One additional note that I know vertically we have 12dp and 12dp. It would be better if we had 8 or 16dp. But the icon looks too small at 32dp and too big at 48dp so unfortunately we have these split boxes in your grid. I hope you're ok with it! I did consider it, but it just didn't work with a different size image.
Thanks for the follow up @osullivanchris 🙇♂️.
Yep I confirm I looked for consistency with the other menus long press tooltip.
Thanks for the clarification and I agree that the spec-ed 32dp seems the best fit dimension we can have there 👍. Changed the me menu width to 64dp here c5184cc, reporting below the resulting image. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
NOTE: I made a quick check with dark mode and AFAIU it seems fine; pinging @khaykov if you can have a look 🙇♂️. Some things I could have doubts are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes @develric ! Code looks good to me, and works as expected :)
Regarding dark mode, I checked the layout, and since it looks the same in both dark and light modes I think it's good :)
I was about to merge it, but found one small issue with icon color - give me a moment to investigate. |
nvm, it was from me modifying code to test a couple of different scenarios :) |
This PR does the following:
MeGravatarLoader > constructGravatarUrl
a bit more consistentTo test
Me menu tooltip on long press
Me
wordMe menu talkback announce
Me
wordRTL support
NOTE
@osullivanchris while working on this PR I was thinking if it could make sense to change the alignment of the Me Menu; currently I did not change things in this PR respect to what we had here but was looking into making the me menu area wider (64dp see image below) so that it aligns on a 16dp end instead of 8dp. I think 48dp is the material design standard menu width tbh but right/end alignment (especially looking to the main FAB at the bottom) looks a bit strange maybe; let me know if there can be some better related guidelines, thanks 😊
PR submission checklist:
RELEASE-NOTES.txt
if necessary.