Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract weekdays to the main strings.xml file #11609

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

maxme
Copy link
Contributor

@maxme maxme commented Apr 8, 2020

Some strings were untranslatable. I moved them from the key_strings.xml file to the main strings.xml file.

Before (French) After (French)
Screenshot_1586333902 Screenshot_1586333782

Note: I did the translation locally, so if you test yourself you'll not see any change unless you update the values-XX/strings.xml file.

@maxme maxme added this to the 14.7 milestone Apr 8, 2020
@maxme maxme requested review from khaykov and nbradbury April 8, 2020 08:23
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for fixing this 🚢

@khaykov khaykov merged commit f15e239 into develop Apr 8, 2020
@khaykov khaykov deleted the issue/make-sitesettings-weekdays-translatable branch April 8, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants