Commenting out the override method shouldOverrideUrlLoading() fixes the issue #11600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerych
requested changes
Apr 7, 2020
WordPress/src/main/java/org/wordpress/android/ui/prefs/LearnMorePreference.java
Outdated
Show resolved
Hide resolved
…ngs/#default-article-settings triggers the calling of shouldOverrideUrlLoading() when it redirects to https://wordpress.com/support/settings/discussion-settings/#default-article-settings. So I just changed the URL in site_settings.xml to point to https://wordpress.com/support/settings/discussion-settings/#default-article-settings directly so that there is no redirect which will trigger shouldOverrideUrlLoading() and result in a blank screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Fixed issue where the URL for the popup does not load due to shouldOverrideUrlLoading()
To test:
In the WordPress app, go to My Sites > Settings > More > Learn More > Website loads correctly
PR submission checklist:
RELEASE-NOTES.txtif necessary.