Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra mocks files #11552

Merged
merged 1 commit into from
May 12, 2020
Merged

Remove extra mocks files #11552

merged 1 commit into from
May 12, 2020

Conversation

jkmassel
Copy link
Contributor

@jkmassel jkmassel commented Mar 28, 2020

To test:
I think all of our UI tests are disabled right now anyway, so this may not matter. But these files shouldn't affect them. We could try re-enabling a test we know to work, or if this breaks something, we could fix it later?

Either way, these seem incorrectly located.

WDYT @rachelmcr?

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jkmassel jkmassel added this to the 14.9 milestone Mar 28, 2020
@jkmassel jkmassel self-assigned this Mar 28, 2020
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@jkmassel jkmassel requested a review from rachelmcr March 28, 2020 23:37
@jkmassel jkmassel marked this pull request as ready for review March 28, 2020 23:37
@rachelmcr
Copy link
Member

Oh, interesting. These are definitely in the wrong location.

However, both of these mocks relate to tests that we've had flaky results from (tests using magic links and editor tests). Before we remove these mocks entirely, it might be worth moving them to the correct location and seeing if they resolve that flakiness.

Copy link
Member

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed my mind since my earlier comment. Since these mocks files aren't being used and are adding clutter, let's remove them now. (The login issue I mentioned before is resolved and the editor issue is tracked in #11897 in case we need to refer back to these removed mocks.)

@rachelmcr rachelmcr merged commit 798024a into develop May 12, 2020
@rachelmcr rachelmcr deleted the remove/extra-mocks-files branch May 12, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants