Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Gutenberg-mobile binary JS bytecode #11436

Closed
wants to merge 10 commits into from
Closed

Use the Gutenberg-mobile binary JS bytecode #11436

wants to merge 10 commits into from

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Mar 12, 2020

This is a draft PR to enable testing wordpress-mobile/gutenberg-mobile#2003 from gutenberg-mobile. The APK produced will load up a binary JS bytecode version for the block editor, resulting in better boot performance.

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest added this to the 14.5 milestone Mar 12, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 12, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@hypest hypest mentioned this pull request Mar 12, 2020
Closed
2 tasks
@hypest
Copy link
Contributor Author

hypest commented Mar 12, 2020

Tried the e2e tests locally but it's the testPublishFullPost failing for me, not the testPublishSimplePost as on CI. I'll rerun the connected tests on CI.

@oguzkocer
Copy link
Contributor

This issue is targeting the current frozen milestone which is about to be released. I am bumping it to 14.6 which is when a PR that lands to develop in the next 2 weeks will be released. If it's more urgent than that, please make sure to target release/14.5 branch which will be available later today and update the milestone for the issue accordingly.

@oguzkocer oguzkocer modified the milestones: 14.5, 14.6 Mar 23, 2020
@oguzkocer
Copy link
Contributor

Hi there! I will be freezing 14.6 in a little bit, to this PR is being bumped to 14.7. If you need this to be shipped in 14.6, please update the base branch to release/14.6 and give me a heads up when the PR is merged so I can release a new beta.

@oguzkocer oguzkocer modified the milestones: 14.6, 14.7 Apr 6, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 7, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@hypest
Build and App setting to select bytecode or not for Gutenberg
cf7de98 
To use:
0. Use a `debug` build variant, the setting is only avail there
1. Put wp.OFFER_GUTENBERG_TEXT_JS_BUNDLE=true in gradle.settings to
reveal the App setting
2. Use the App setting to select bytecode or not for Gutenberg's JS
bundle
@hypest hypest force-pushed the gutenberg/try-hermes-bytecode branch from d7d9ae9 to cf7de98 Compare April 8, 2020 10:44
@oguzkocer
Copy link
Contributor

Hi there! 14.7 is being frozen, so this PR is being bumped to 14.8. If these changes have to be shipped with 14.7, please target release/14.7 and cc me in the PR so I can cut a new beta release. Also if you can keep the release dates in mind and bump the PRs & issues you are working on before the code freeze date, we'd really appreciate it.

P.S: I am still working on the messaging for these bumps, so please let me know if you have any questions/concerns/feedback.

@oguzkocer oguzkocer modified the milestones: 14.7, 14.8 Apr 20, 2020
@oguzkocer
Copy link
Contributor

Hi there! 14.8 is being frozen, so this PR is being bumped to 14.9. If these changes have to be shipped with 14.8, please target release/14.7 and cc me in the PR so I can cut a new beta release. Also if you can keep the release dates in mind and bump the PRs & issues you are working on before the code freeze date, we'd really appreciate it.

Extra note:
@hypest Looks like this PR is being bumped for the 4th time, should we either remove the milestone or add one that's more reflective of the intention of when it'll be merged?

@oguzkocer oguzkocer modified the milestones: 14.8, 14.9 May 4, 2020
@hypest hypest removed this from the 14.9 milestone May 4, 2020
@hypest
Copy link
Contributor Author

hypest commented May 4, 2020

Removed the milestone flagging, at least until this PR comes out of the Draft state, thanks for the suggestion Oguz 👍.

@hypest hypest mentioned this pull request Nov 5, 2020
Closed
3 tasks
@hypest
Copy link
Contributor Author

hypest commented Nov 9, 2020

No need for this PR anymore, see #13297 (comment).

@hypest hypest closed this Nov 9, 2020
@hypest hypest deleted the gutenberg/try-hermes-bytecode branch December 20, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hypest @oguzkocer