Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA Reader: fix potential issue with version update or language change #11390

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

develric
Copy link
Contributor

@develric develric commented Feb 26, 2020

Fixes two issues found while working on another PR related to Reader.

  1. Upgrading from previous version can make the reader be wrongly selecting the Following tab
  2. Changing app language when Reader was last in Discover tab (actually should be the same if the reader is in a tab not being Following) cause the reader to not auto-refresh posts first time user goes to reader again

Below steps to reproduce the issue and to test this PR.

Test Cases

Test case 1

Upgrade to 14.3 version from a previous installed one.

To Reproduce

  • Remove other app version if installed and from AS checkout, for example, version 14.0 tag, compile and run on the device/emu
  • Open the app and go to the Reader (you should be in the Followed Sites stream)
  • Close the app
  • From AS checkout version 14.3-rc1 tag, compile and run on the device/emu to update current installation
  • Opening the app you will be in the reader Discover content without the subfilter (as it should be) but Following tab is wrongly selected

To Test

  • Remove other app version if installed and from AS checkout version 14.0 tag, compile and run on the device/emu
  • Open the app and go to the Reader (you should be in the Followed Sites stream)
  • Close the app
  • From AS checkout the version from this PR, compile and run on the device/emu to update current installation
  • Opening the app you will be in the reader Discover content without the subfilter and Discover tab correctly selected

Test case 2

Change language does not auto-update posts first time going to reader. (NB: since as a solution in the code we are resetting the Shared Prefs for selected reader when changing language, even if you selected another tab before to change language you will be brought always in Discover first time right after changing language)

To Reproduce

  • Remove other app version if installed and from AS checkout version 14.3-rc1 tag, compile and run on the device/emu
  • Open the app, go to the Reader and select Discover tab
  • Change app language from app settings then come back to Reader
  • Check that you are set in Following (first) tab and posts are not loaded

- Changing tab or closing/opening the app restores normal working conditions

To Test

  • From AS install the current PR version
  • Open the app, go to the Reader and select Discover tab
  • Change app language from app settings then come back to Reader
  • Check you are in Discover tab and posts are loaded

Test case 3 - Smoke test rules of thumbs

Smoke test the reader, if possible use both wp.com and self-hosted sites and here below some of the steps for smoke testing but feel free to add 😊 :

  • Move between tabs
  • Use the subfilter to select different sources (Sites/Tags) to navigate
  • Open posts from the reader
  • Save posts for later and open them from the SAVED tab (both WP.com and self-hosted)
  • Follow/Unfollow tags/sites from the Reader (only for WP.com)
  • Follow/Unfollow tags/sites from the Setting (only for WP.com)
  • Whatever else you can think of 😊...

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@develric develric requested a review from khaykov February 27, 2020 14:29
@develric develric self-assigned this Feb 27, 2020
@develric develric marked this pull request as ready for review February 27, 2020 14:55
@develric develric removed their assignment Feb 27, 2020
@khaykov khaykov self-assigned this Feb 27, 2020
Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @develric ! I was able to reproduce the issue and confirm that the fix is working 👍

@khaykov khaykov merged commit 4aa6c6e into release/14.3 Feb 27, 2020
@jkmassel jkmassel deleted the issue/ia-reader-version-update-lang-change branch October 17, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants