Fix gallery size labels - 1.22.0 #11236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test the changes on this Pull Request by downloading the APK here. |
|
Tried out the Peril-built WordPress-pr-11236-build-35907.apk and I see empty Image size options on Android 10, Pixel 2XL, when having a gallery with 2 images from the WP Media Library. (FWIW, works OK for me on WPiOS, Peril build 21887)
|
|
Tried again, installing both a locally built vanillaRelease and the same Peril build as before and I see no issue with "empty dialog" 🎉. There must have been some issue with how the Peril build was installed before. |
…grate_release_1.22.0-fix-gallery-size-labels
Generated by 🚫 dangerJS |
mkevins
deleted the
gutenberg/integrate_release_1.22.0-fix-gallery-size-labels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR:
gutenberg: WordPress/gutenberg#20045gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1856WordPress-iOS: wordpress-mobile/WordPress-iOS#13375Description
This brings the fix from WordPress/gutenberg#19800 to the release branch for
1.22.0and updates the release notes to reflect the new feature.How has this been tested?
Tested via steps here: WordPress/gutenberg#19800 (comment)
PR submission checklist:
RELEASE-NOTES.txtif necessary.