Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Integrates Media Editing button listener #11175

Merged
merged 4 commits into from
Jan 28, 2020
Merged

[Gutenberg] Integrates Media Editing button listener #11175

merged 4 commits into from
Jan 28, 2020

Conversation

leandroalonso
Copy link
Contributor

Depends on #11174

Integrates the changes that add the Media Editing icon over images in Gutenberg.

The button is hidden for Android but this PR is needed in order to avoid compiling errors.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@leandroalonso leandroalonso added [Type] Task Gutenberg Editing and display of Gutenberg blocks. gutenberg-mobile labels Jan 27, 2020
@leandroalonso leandroalonso added this to the 14.2 milestone Jan 27, 2020
@leandroalonso leandroalonso changed the title Integrates Media Editing button listener [Gutenberg] Integrates Media Editing button listener Jan 27, 2020
@leandroalonso leandroalonso mentioned this pull request Jan 27, 2020
Merged
2 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 27, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

mchowning
mchowning approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Don't forget to update the submodule ref after the gutenberg-mobile PR is merged.

@leandroalonso leandroalonso merged commit 41c618a into develop Jan 28, 2020
@leandroalonso leandroalonso deleted the issue/integrate_media_editor_button_changes branch January 28, 2020 17:15
@leandroalonso leandroalonso mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

@etoledom etoledom Awaiting requested review from etoledom

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Task
Projects
None yet
Milestone
14.2
Development

Successfully merging this pull request may close these issues.
2 participants
@leandroalonso @mchowning