Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Update to v1.21.0 #11117

Merged
merged 11 commits into from
Jan 23, 2020
Merged

[Gutenberg] Update to v1.21.0 #11117

merged 11 commits into from
Jan 23, 2020

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Jan 20, 2020 •
edited
Loading

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1788

Changes:

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added this to the 14.1 milestone Jan 20, 2020
@etoledom etoledom requested a review from maxme January 20, 2020 22:30
@etoledom etoledom self-assigned this Jan 20, 2020
@etoledom etoledom mentioned this pull request Jan 20, 2020
Merged
@etoledom etoledom marked this pull request as ready for review January 21, 2020 17:02
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 21, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

maxme
maxme reviewed Jan 23, 2020
View reviewed changes
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I confirm the margins are smaller.

@maxme maxme self-requested a review January 23, 2020 15:21
maxme
maxme approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@maxme maxme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested the editor and everything seems fine.

I don't see any mention to the shortcode block in 14.0 or 14.1. It was introduced in gutenberg mobile 1.20.0 so I think it shipped with wpandroid 14.0.

I think we should add a line to 14.1 even if we're one release late: "We were so focused on improving the app that we forgot to tell you a new shortcode block was introduced in 14.0"

@maxme
Copy link
Contributor

maxme commented Jan 23, 2020

I think we should add a line to 14.1 even if we're one release late: "We were so focused on improving the app that we forgot to tell you a new shortcode block was introduced in 14.0"

Actually shortcode was added after the 14.0 branch cut, so we're fine here. I'll update the release notes.

@etoledom
Copy link
Contributor Author

Thank you @maxme for the review and for adding the missing release notes 🙏

@etoledom etoledom merged commit 4bbce5b into develop Jan 23, 2020
@etoledom etoledom deleted the gutenberg/integrate_release_1.21.0 branch January 23, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxme maxme maxme approved these changes

Assignees

@etoledom etoledom

Labels
None yet
Projects
None yet
Milestone
14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @maxme