-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA Feature Flag remove for me move and create fab v1 #11074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f zendesk HelpActivity from notifications.
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java
…his version from previous one.
develric
changed the title
Feature/ia me move create fab v1
IA Feature Flag remove for me move and create fab v1
Jan 12, 2020
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR is based and needs #11064 and #11069. So those 2 should be first merged in develop before to merge this one.
This PR has been created to remove the IA feature flag (
INFORMATION_ARCHITECTURE_AVAILABLE
) for the features listed below so to have them released in vanilla develop for beta testing/release.What needs to be checked
1. Access to the Me screen was moved
We removed the Me screen access from the bottom navigation bar and we moved it to be a menu icon in the My Site screen.
To test
2. Possibility to create a new post or page from My Site
We removed the New Post menu item from the bottom navigation bar in favor of a FAB button in My Site. The FAB button opens a bottom sheet from which it is possible to create a new Blog Post and also a new Site Page. The feature is announced by a tooltip according the logic reported in the test steps below.
To test
3. QuickStart reviewed based on new IA architecture (some more info in #11042 if needed)
In the IA project we removed the add post button in the main navigation bottom bar. As a result of this, the QuickStart tutorials are still ok, but the PUBLISH_POST_TUTORIAL that was targeting the removed bottom button is no more ok. We aligned the
PUBLISH_POST_TUTORIAL
to theCREATE_NEW_PAGE
behavior. That is targeting therow_blog_posts
in the My Site list of sections (in analogy to therow_pages
targeted by theCREATE_NEW_PAGE
tutorial)To test
4. Reader + Notifications unchanged
The IA Reader modifications are still behind the
INFORMATION_ARCHITECTURE_AVAILABLE
feature flag that was released in the develop branch in 13.8. Since we did not touch the related code we should expect no difference in behavior.To test
To complete this check smoke test the
Reader
andNotifications
sections.Notes
While working on this PR we found the following:
launchZendeskMyTickets
the previous code version was doing amBottomNav.setCurrentSelectedPage(PageType.ME)
so that in case of a zendesk support push notification tapped by the user, when user comes back from the HelpActivity user can found the Me page selected. Now we removed the ME page from the bottom sheet so we made here amBottomNav.setCurrentSelectedPage(PageType.MY_SITE)
and we launch theHelpActivity
by a newly added funtion (viewHelpAndSupportInNewStack
) that populates the back stack correctly. In this way the UX should be fixed. To test this one:My tickets
opened.Help and Support
,Me
,My Site
)PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txt
if necessary.