Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navigation Bar Buttons Not Visible with Signup Sheet #11051

Merged
merged 17 commits into from
Feb 12, 2020
Merged

Fix Navigation Bar Buttons Not Visible with Signup Sheet #11051

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
93f7493
Fix signup bottom sheet navigation bar buttons not visible issue
ashiagr Jan 7, 2020
98c445c
Convert BottomSheetDialog to BottomSheetDialogFragment and update styles
ashiagr Jan 13, 2020
4fd8960
Avoid using a parameter in Fragment's constructor
ashiagr Jan 13, 2020
d15dd92
Remove dialog.setOnDismissListener
ashiagr Jan 14, 2020
1d51b1f
Eliminate setRetainInstance(true)
ashiagr Jan 14, 2020
8dcfbc7
Eliminate logic to manually recreate the dialog(fragment)
ashiagr Jan 14, 2020
e0e8327
Extract parts of code from onCreateView to onViewCreated
ashiagr Jan 14, 2020
db32c52
Remove empty line after brace
ashiagr Jan 14, 2020
9816868
Show full width navigation bar and restrict max width for large screens
ashiagr Jan 21, 2020
07eb798
Update libs/login/WordPressLoginFlow/src/main/java/org/wordpress/andr…
ashiagr Jan 22, 2020
042eb3b
Add null check for design_bottom_sheet layout
ashiagr Jan 22, 2020
12a221c
Merge branch 'issue/10908-navigation-bar-buttons-not-visible-with-sig…
ashiagr Jan 22, 2020
65318de
Add max-width for bottom sheet in landscape mode
ashiagr Jan 27, 2020
0666345
Add max-width for bottom sheet in landscape mode for phones
ashiagr Jan 29, 2020
081ca1a
Merge branch 'develop' into issue/10908-navigation-bar-buttons-not-vi…
ashiagr Jan 29, 2020
f963bc2
Fix bottom sheet not disappearing after rotation
ashiagr Feb 11, 2020
9fa9606
Merge branch 'develop' into issue/10908-navigation-bar-buttons-not-vi…
ashiagr Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...WordPressLoginFlow/src/main/java/org/wordpress/android/login/SignupBottomSheetDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

import android.content.Context;
import android.content.DialogInterface;
import android.os.Build;
import android.text.Html;
import android.view.LayoutInflater;
import android.view.View;
import android.view.Window;
import android.widget.Button;

import androidx.annotation.NonNull;
Expand Down Expand Up @@ -66,6 +68,28 @@ public void onShow(DialogInterface dialog) {
});
}

@Override
public void onStart() {
super.onStart();
// Fix to show navigation bar buttons when the signup bottom sheet is shown
// on Android versions API 27 and above. They get shadowed or invisible otherwise.
if (getWindow() != null && Build.VERSION.SDK_INT >= Build.VERSION_CODES.O_MR1) {
Window window = getWindow();

// You can find the bottom sheet coordinator layout container id here: https://git.io/JejbO
View containerView = window.findViewById(com.google.android.material.R.id.container);
if (containerView != null) {
containerView.setFitsSystemWindows(false);

// dark navigation bar icons
View decorView = window.getDecorView();
decorView.setSystemUiVisibility(
decorView.getSystemUiVisibility() | View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR
);
}
}
}

public interface SignupSheetListener {
void onSignupSheetCanceled();
void onSignupSheetEmailClicked();
Expand Down
1 change: 1 addition & 0 deletions libs/login/WordPressLoginFlow/src/main/res/layout-land/signup_bottom_sheet_dialog.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
android:layout_height="match_parent"
android:layout_width="match_parent"
android:orientation="vertical"
android:fitsSystemWindows="true"
android:paddingBottom="@dimen/margin_extra_large"
android:paddingLeft="@dimen/margin_extra_large"
android:paddingRight="@dimen/margin_extra_large"
Expand Down
1 change: 1 addition & 0 deletions libs/login/WordPressLoginFlow/src/main/res/layout/signup_bottom_sheet_dialog.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
android:layout_height="match_parent"
android:layout_width="match_parent"
android:orientation="vertical"
android:fitsSystemWindows="true"
android:paddingBottom="@dimen/margin_extra_large"
android:paddingLeft="@dimen/margin_extra_large"
android:paddingRight="@dimen/margin_extra_large"
Expand Down