Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Signup Interstitial: Create interstitial screen #10933

Merged
merged 9 commits into from
Dec 13, 2019
Merged

Post-Signup Interstitial: Create interstitial screen #10933

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3ae56f5
Creating post-signup interstitial layout
renanferrari Dec 9, 2019
0caee3e
Implementing basic functionality of post-signup interstitial buttons
renanferrari Dec 10, 2019
3bf6ef5
Adding post-signup interstitial screen title for accessibility
renanferrari Dec 11, 2019
383fb60
Adding landscape layout for post-signup interstitial screen
renanferrari Dec 11, 2019
6a3b432
Removing TODO comments
renanferrari Dec 12, 2019
d7f699c
Updating strings to reuse existing ones
renanferrari Dec 12, 2019
8c74b88
Marking reused strings as not translatable
renanferrari Dec 12, 2019
e462add
Updating max width setting for post-signup interstitial screen
renanferrari Dec 13, 2019
866c12a
Updating post-signup interstitial illustration to use color references
renanferrari Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions WordPress/src/main/res/layout/post_signup_interstitial_default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,30 @@
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintVertical_chainStyle="packed" />

<TextView
<org.wordpress.android.widgets.WPTextView
android:id="@+id/title_view"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/margin_medium"
android:text="@string/post_signup_interstitial_title"
android:textAlignment="center"
android:textAppearance="@style/TextAppearance.AppCompat.Title"
app:fixWidowWords="true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, 👍 I actually forgot about that one ;)

app:layout_constraintBottom_toTopOf="@+id/subtitle_view"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@+id/illustration_view"
app:layout_constraintWidth_max="@dimen/post_signup_interstitial_max_width" />

<TextView
<org.wordpress.android.widgets.WPTextView
android:id="@+id/subtitle_view"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/margin_extra_extra_large"
android:text="@string/post_signup_interstitial_subtitle"
android:textAlignment="center"
android:textAppearance="@style/TextAppearance.AppCompat.Subhead"
app:fixWidowWords="true"
app:layout_constraintBottom_toTopOf="@+id/create_new_site_button"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand Down
6 changes: 4 additions & 2 deletions WordPress/src/main/res/layout/post_signup_interstitial_landscape.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,29 +26,31 @@
android:orientation="vertical"
app:layout_constraintGuide_percent="0.45" />

<TextView
<org.wordpress.android.widgets.WPTextView
android:id="@+id/title_view"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/margin_medium"
android:text="@string/post_signup_interstitial_title"
android:textAlignment="center"
android:textAppearance="@style/TextAppearance.AppCompat.Title"
app:fixWidowWords="true"
app:layout_constraintBottom_toTopOf="@+id/subtitle_view"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="@+id/guideline"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintVertical_chainStyle="packed"
app:layout_constraintWidth_max="@dimen/post_signup_interstitial_max_width" />

<TextView
<org.wordpress.android.widgets.WPTextView
android:id="@+id/subtitle_view"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/margin_extra_medium_large"
android:text="@string/post_signup_interstitial_subtitle"
android:textAlignment="center"
android:textAppearance="@style/TextAppearance.AppCompat.Subhead"
app:fixWidowWords="true"
app:layout_constraintBottom_toTopOf="@+id/create_new_site_button"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="@+id/guideline"
Expand Down
6 changes: 4 additions & 2 deletions WordPress/src/main/res/values/dimens.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,9 @@
<dimen name="progress_spinner_small">24dp</dimen>

<!-- post-signup interstitial -->
<dimen name="post_signup_interstitial_max_width">512dp</dimen>
<dimen name="post_signup_interstitial_max_width">
@dimen/actionable_empty_view_text_maximum_width
</dimen>

<!--plugins-->
<dimen name="plugin_row_width">116dp</dimen>
Expand Down Expand Up @@ -448,7 +450,7 @@
<!--preferences master switch -->
<dimen name="notifications_tab_dialog_toolbar_content_offset">24dp</dimen>
<dimen name="notifications_settings_dialog_divider_height">1dp</dimen>

<!--Main bottom sheet icon size -->
<dimen name="main_bottom_sheet_list_row_icon_size">32dp</dimen>

Expand Down