Fix NPE in UploadService #10388
Merged
Fix NPE in UploadService #10388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2019
mkevins
reviewed
Aug 16, 2019
WordPress/src/main/java/org/wordpress/android/ui/uploads/UploadService.java
Show resolved
Hide resolved
4 tasks
mkevins
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10001
Fixes NPE in UploadService. We check that
sInstancefield is not null. However, before we use that fieldonDestroymethod which clears the field might be have been called by the system. This PR fixes the issue by temporarily storing thesInstanceinto a local field.To test:
This issue isn't easy to reproduce. I'd suggest just carefully reviewing the code.
Update release notes: