Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show publish confirmation dialog on submit for review #10311

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Jul 31, 2019

Fixes #10298

Do not show publish confirmation dialog when the user clicks on Submit button on a post list item.

To test:

  1. Log in as contributor
  2. Create a draft and do not upload it (leave the editor by pressing back button)
  3. Click on the Submit button on the post list item
  4. Notice the post gets submitted for review and the publish confirmation dialog is not shown

Update release notes:

  • the changes are too minor

@malinajirka malinajirka added this to the 13.1 milestone Jul 31, 2019
@malinajirka malinajirka requested review from maxme, shiki and 0nko July 31, 2019 12:50
@0nko 0nko self-assigned this Aug 1, 2019
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The test worked as described.

We can merge once the connected tests are fixed.

@malinajirka
Copy link
Contributor Author

@jtreanor Afaiu we can ignore the failing connected tests for now, right?

Thanks Onko for the review!;)

@jtreanor
Copy link
Contributor

jtreanor commented Aug 1, 2019

@malinajirka Yes, absolutely! Sorry about that 😞

@0nko
Copy link
Contributor

0nko commented Aug 1, 2019

Thanks @jtreanor! :shipit:

@0nko 0nko merged commit e1d2c87 into develop Aug 1, 2019
@0nko 0nko deleted the issue/10298-remove-confirmation-dialog-on-submit branch August 1, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish confirmation dialog shown when submitting for review
3 participants