Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release 12.9 into develop #10248

Merged
merged 15 commits into from
Jul 19, 2019
Merged

Merge release 12.9 into develop #10248

merged 15 commits into from
Jul 19, 2019

Conversation

loremattei
Copy link
Contributor

Merge release 12.9 into develop

@loremattei loremattei added the Releases Label related to managing releases label Jul 18, 2019
@loremattei loremattei requested review from jkmassel and jtreanor July 18, 2019 13:55
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

jkmassel
jkmassel approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Has the new store strings
✅ Has the updated build tooling
✅ Version numbers are going up, which is the direction we want them to go
✅ :shipit:

@loremattei loremattei merged commit 091e249 into develop Jul 19, 2019
@loremattei loremattei deleted the merge-release-12.9-into-develop branch July 19, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkmassel jkmassel jkmassel approved these changes

@jtreanor jtreanor Awaiting requested review from jtreanor

Assignees
No one assigned
Labels
Releases Label related to managing releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loremattei @jkmassel @daniloercoli