Address AT issues after domain registration #10101

khaykov · 2019-06-24T21:46:58Z

This PR can be reviewed right now, but merged after Flux-C counterpart is merged, and correct commit has is reflected in this branch.

Update:
After more testing with more than 50 domains, I realized that there is not 100% sure way to do AT after fresh domain registration without some sort of problem. Most common ones are:

Primary domain switches to "wpcomstaging".
AT get's stuck even on empty site.
AT errors out for some reason.

Additional issue: when you install a plugin during AT there is some sort of server-side delay, between completion of AT and when the plugin is marked as installed. This often times happen when you perform AT on freshly registered domains (

PR adds a delay/retry logic for domain registration and fetching plugin details.

In addition, this PR removes the "Congratulations" screen after the successful domain registration during AT. Instead, we immediately prompt used to start Automated Transfer after the domain is registered.

Sometimes domain is not ready for AT, so we notify used about this.
Sometimes everything works!

To test:

On a Simple site without a Custom Domain and with a Domain Credit, perform an AT by installing a plugin and registering a domain.
When domain is registered, notice that AT prompt is visible.
Installing a plugin will either work and you will see an error message, that site is not yet ready.
When AT is complete, notice that "INSTALL" button of plugin changes to "INSTALLED".

PS: viewDomainRegistrationActivity in ActivityLauncher is left for compatibility with develop branch.

Update release notes:

If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

…ugin directory.

automattic-ian · 2019-06-25T12:31:01Z

A 10 second delay should be plenty for smaller simple sites with not much content, but please bear in mind there are some pretty common scenarios when a 10 second delay, may not be enough.

I've seen larger sites (ex those with thousands of posts/pages/media library items) take much longer, in some instances I have seen a delay of more than 2 minutes.

If possible I would recommend, adding a check to change the delay based on post count, and increase it a bit if the site is quite large.

khaykov · 2019-06-25T14:42:08Z

Thanks, @automattic-ian ! That's a great insight. If time varies like this, I think I'll try some other approach instead of just a flat delay.

Removed "Congrats" screen after domain registration. Start plugin installation imidiately after domain registration is complete.

…gure action after AT.

WordPress/src/test/java/org/wordpress/android/util/NoDelayCoroutineDispatcher.kt

planarvoid · 2019-06-27T11:18:25Z

WordPress/src/main/java/org/wordpress/android/ui/domains/DomainRegistrationActivity.kt

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        setContentView(R.layout.activity_domain_suggestions_activity)

+        domainRegistrationPurpose = intent.getSerializableExtra(DOMAIN_REGISTRATION_PURPOSE_KEY)
+                as DomainRegistrationPurpose


I don't think this is correct. This will work if the DOMAIN_REGISTRATION_PURPOSE_KEY is in the intent, if it isn't, it will try to cast null to DomainRegistrationPurpose and it will fail because DomainRegistrationPurpose is not nullable. I think we have to cast it to DomainRegistrationPurpose? or use as? DomainRegistrationPurpose. This assumption is based on https://kotlinlang.org/docs/reference/typecasts.html#unsafe-cast-operator

Do you really need to keep the org.wordpress.android.ui.ActivityLauncher#viewDomainRegistrationActivity? It is unused so the DomainRegistrationPurpose should always be there. You can change var domainRegistrationPurpose: DomainRegistrationPurpose? = null to lateinit var domainRegistrationPurpose: DomainRegistrationPurpose so it doesn't have to be nullable.

Good catch! I added a null guard using as? and left it nullable for now, since it will be called using viewDomainRegistrationActivity from develop branch, and I want to reduce conflicts when merging this back into it.

I'll change it to lateinit in next domain related PR 👍

WordPress/src/main/java/org/wordpress/android/ui/domains/DomainRegistrationActivity.kt

planarvoid · 2019-06-27T12:11:49Z

WordPress/src/test/java/org/wordpress/android/util/NoDelayCoroutineDispatcher.kt

+import kotlin.coroutines.resume
+
+@UseExperimental(InternalCoroutinesApi::class)
+class NoDelayCoroutineDispatcher : CoroutineDispatcher(), Delay {


good idea 👍

…domainRegistrationPurpose.

khaykov · 2019-06-28T05:36:37Z

Changed error message and moved it into a dialog from toast 👍

planarvoid

Looks good 👍 thanks for the changes 💯

…Android into issue/10100-accounting-for-server-side-delay-during-some-requests # Conflicts: # build.gradle

Adding a 10 seconds delay between completion of AT and fetching of pl…

0a44f51

…ugin directory.

khaykov added the Plugins label Jun 24, 2019

khaykov added this to the 12.7 ❄️ milestone Jun 25, 2019

Added retry logic for fetching plugin directory.

2ee6582

Removed "Congrats" screen after domain registration. Start plugin installation imidiately after domain registration is complete.

khaykov changed the title ~~Add a 10 seconds delay between completion of AT and fetching of plugin directory.~~ Address delayed plugin directory updated during AT on fresh domain Jun 26, 2019

Fixed request code, updated logging, removed redundant code.

e40005e

khaykov requested review from 0nko, nbradbury and planarvoid June 26, 2019 05:16

Increased plugin retry delay to 10 seconds.

0f531df

khaykov added the [Status] Not Ready for Review label Jun 26, 2019

khaykov added 6 commits June 26, 2019 02:19

Added descriptive SSL error message, delay when registering domain name.

effc139

Naming.

8fbb918

Changed action after domain registration and dispatching plugin confi…

4093d05

…gure action after AT.

Removed dedicated message for no ssl error in favor of more general one.

79797c1

Manually setting domain as a primary after it registered.

d845303

Updated tests.

58baf9e

khaykov changed the title ~~Address delayed plugin directory updated during AT on fresh domain~~ Address AT issues after domain registration Jun 26, 2019

Fixed checkstyle issues, naming.

0491d03

wpmobilebot reviewed Jun 26, 2019

View reviewed changes

WordPress/src/test/java/org/wordpress/android/util/NoDelayCoroutineDispatcher.kt Outdated Show resolved Hide resolved

Removed multispaces.

5d469e1

khaykov removed the [Status] Not Ready for Review label Jun 27, 2019

planarvoid reviewed Jun 27, 2019

View reviewed changes

planarvoid self-assigned this Jun 27, 2019

khaykov added 2 commits June 27, 2019 07:13

Null guard for DomainRegistrationPurpose passed with intent, private …

afa7ffe

…domainRegistrationPurpose.

Updated error message handling.

28b3905

planarvoid approved these changes Jun 28, 2019

View reviewed changes

khaykov added 2 commits June 28, 2019 07:39

Fresh flux-c commit hash.

066fd32

Merge branch 'release/12.7' of github.com:wordpress-mobile/WordPress-…

051dba7

…Android into issue/10100-accounting-for-server-side-delay-during-some-requests # Conflicts: # build.gradle

khaykov merged commit 2ee4b63 into release/12.7 Jun 28, 2019

khaykov deleted the issue/10100-accounting-for-server-side-delay-during-some-requests branch June 28, 2019 14:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address AT issues after domain registration #10101

Address AT issues after domain registration #10101

khaykov commented Jun 24, 2019 •

edited

Loading

automattic-ian commented Jun 25, 2019

khaykov commented Jun 25, 2019

planarvoid Jun 27, 2019 •

edited

Loading

khaykov Jun 27, 2019 •

edited

Loading

planarvoid Jun 27, 2019

khaykov commented Jun 28, 2019

planarvoid left a comment

Address AT issues after domain registration #10101

Address AT issues after domain registration #10101

Conversation

khaykov commented Jun 24, 2019 • edited Loading

automattic-ian commented Jun 25, 2019

khaykov commented Jun 25, 2019

planarvoid Jun 27, 2019 • edited Loading

Choose a reason for hiding this comment

khaykov Jun 27, 2019 • edited Loading

Choose a reason for hiding this comment

planarvoid Jun 27, 2019

Choose a reason for hiding this comment

khaykov commented Jun 28, 2019

planarvoid left a comment

Choose a reason for hiding this comment

khaykov commented Jun 24, 2019 •

edited

Loading

planarvoid Jun 27, 2019 •

edited

Loading

khaykov Jun 27, 2019 •

edited

Loading