Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign up: Ensure tracks events are not anonymous after signing up #7856

Closed
aerych opened this issue Jun 4, 2018 · 1 comment
Closed

Sign up: Ensure tracks events are not anonymous after signing up #7856

aerych opened this issue Jun 4, 2018 · 1 comment
Assignees
@aerych
Labels
Signup
Milestone
10.2

Comments

@aerych
Copy link
Member

aerych commented Jun 4, 2018 •
edited
Loading

After creating a new account the Tracks anonymous ID should no longer be used, and the account_created event itself should be sent as a logged in user.
See here and here for the relevant tracks code. We need to make sure mNosaraClient.trackAliasUser is being properly called from the sign up flow.
@aerych aerych added the Signup label Jun 4, 2018
@aerych aerych added this to the 10.2 milestone Jun 4, 2018
@aerych aerych mentioned this issue Jun 8, 2018
Merged
@aerych aerych self-assigned this Jun 8, 2018
oguzkocer added a commit that referenced this issue Jun 12, 2018
@oguzkocer
Merge pull request #7880 from /issues/7856-refresh-meta-data
3e6e6a4 
Issues/7856 refresh meta data
@loremattei
Copy link
Contributor

Closed via #7880.

aforcier added a commit that referenced this issue Oct 3, 2018
@aforcier
Squashed 'libs/login/' changes from d3c0fa7ae4..d6e2bf4184
f43cbb4 
d6e2bf4184 Update login library default FluxC hash
7b3ba9e906 Merge commit 'e500cd63388ba77e7ea13df2fbb199c64e7107c2' into feature/import-latest-login-lib
0fe4cc1bf0 Merge commit '554b41f85535e113b1357e1c708fe304d50e0bd0' into develop
4495659338 Fix text of email not found error
ab65b7ea6e Fix text of sms throttled error
9f2e660eeb Checkstyle fix
61d3e7020e Refactoring
dd3989bbfa Refactoring
5cac71b526 Fix log msgs
42eb5f7300 Set image content description or mark it as not important for accessibility
bb0e745946 Fix checkstyle
0904ff17a5 Add a meaningful error message when the 2fa loggin is stopped because of sms throttling
606eb6fbe6 Trigger 2fa when the authentication SMS has been already sent during the flow
0f27a678d5 Fix google sign in flow
c98a1d473a Fix signup/in flows
30bf1accd1 Fix google sign-up
916621c9d7 Support setting the scheme in LoginMagicLinkRequestFragment
88e73ab293 Login integration
81fa3c9812 Add WP.com login as a step after Jetpack install
e3dd86f22b Localize the error message for invalid 2fa codes
08af882ab2 Merges release/10.2 into develop
7f9fca95f7 Update gradle plugin to 3.1.3
2520aa3844 Update google repository config and list it first
a88a7195ad Merge pull request #7880 from /issues/7856-refresh-meta-data
f2a12f0e4c fixed merge conflict
b218f90a2d Clean up from previous approach.
6ce03885e1 Remove errant space from login string
df7ae86a4d Update login library string to reflect core app string update
078c9c86f8 Remove unused strings from login library
51b07d7776 Tweak logic to allow a single method to bump acct created
17ede53ffc Overload method to have a shorter name.
33326b183b Refresh metadata for the google signup flow.
65c96baefa Call new method when bumping account created stat.
afedb2008a bumped google play services version to 15.0.1
853823cd9a Merge pull request #217 from woocommerce/feature/113-login-notification
848294dc29 Use more generic naming for the login notification channel id
fa437d344f Merge commit '09a0852581dd9a3a6b15109f3a8e9a80e644fbbb' into feature/update-login-library
6b07a925db Enable Google login
066beded26 Update gradle plugin to 3.1.2
3e1abf1cf0 Fix FluxC build error in login library
37707a744c Merge pull request #188 from woocommerce/feature/gradle-3.1.1
1a933195f0 Update gradle plugin and support libraries to latest
9af7502466 Update inner import checkstyle violations in login library
d07401c892 Update IDEA style config files
ad4fc3b429 Revert unintentional color change in the WordPressLoginFlow module.
c1b56716a1 Merge branch 'feature/order-details-screen' into feature/order-detail-views
6c93c92dc5 Exclude utils library from FluxC imports
372719093e Merge branch 'develop' into feature/order-detail-views
eec28986b5 Restore login notification styling changes
103dd8f6a1 Merge commit '6bd01d64a2d01176f5b26ae36836d4f5ff0fcdc9' into feature/update-login-lib
97462cca8e Merge branch 'develop' into feature/order-detail-views
20e9f3b9e3 Move login icon colors to variables
b15f6632fa Merge branch 'develop' into feature/114-login-style-refactor
26d1088134 Fix style violations in login library
17326beace Order Details - Customer Info View - Action Icons and listeners, updated icon assets * Add the ability to click to dial customer phone * Add the ability to click to email customer * Add the ability to click to sms customer
ebfa842faf Make login notification styling overridable
5494d0e742 Make login toolbar styling overridable
8cbdb5b313 Use overridable color names in login flow styles
e9137fe9f7 Replace WordPress buttons with LoginTheme
bf34dabb71 Expose play-services-auth dependency from login library
19203891d7 Merge commit '9751124a62caad5f7c9af772f8b872b604cd02b9' into feature/gradle-3.0
f5b58af6b4 Add WPCOM_LOGIN_ONLY LoginMode, disallowing self-hosted login

git-subtree-dir: libs/login
git-subtree-split: d6e2bf41845cba12bcfc24cde4e21aef032d89e4
aforcier added a commit that referenced this issue Oct 18, 2018
@aforcier
Squashed 'libs/login/' changes from d3c0fa7ae4..4896a91c7c
1042a27 
4896a91c7c Merge pull request #6 from wordpress-mobile/merge-wca
16a871bcf1 Set base button color to white
d6e2bf4184 Update login library default FluxC hash
7b3ba9e906 Merge commit 'e500cd63388ba77e7ea13df2fbb199c64e7107c2' into feature/import-latest-login-lib
0fe4cc1bf0 Merge commit '554b41f85535e113b1357e1c708fe304d50e0bd0' into develop
4495659338 Fix text of email not found error
ab65b7ea6e Fix text of sms throttled error
9f2e660eeb Checkstyle fix
61d3e7020e Refactoring
dd3989bbfa Refactoring
5cac71b526 Fix log msgs
42eb5f7300 Set image content description or mark it as not important for accessibility
bb0e745946 Fix checkstyle
0904ff17a5 Add a meaningful error message when the 2fa loggin is stopped because of sms throttling
606eb6fbe6 Trigger 2fa when the authentication SMS has been already sent during the flow
0f27a678d5 Fix google sign in flow
c98a1d473a Fix signup/in flows
30bf1accd1 Fix google sign-up
916621c9d7 Support setting the scheme in LoginMagicLinkRequestFragment
88e73ab293 Login integration
81fa3c9812 Add WP.com login as a step after Jetpack install
e3dd86f22b Localize the error message for invalid 2fa codes
08af882ab2 Merges release/10.2 into develop
7f9fca95f7 Update gradle plugin to 3.1.3
2520aa3844 Update google repository config and list it first
a88a7195ad Merge pull request #7880 from /issues/7856-refresh-meta-data
f2a12f0e4c fixed merge conflict
b218f90a2d Clean up from previous approach.
6ce03885e1 Remove errant space from login string
df7ae86a4d Update login library string to reflect core app string update
078c9c86f8 Remove unused strings from login library
51b07d7776 Tweak logic to allow a single method to bump acct created
17ede53ffc Overload method to have a shorter name.
33326b183b Refresh metadata for the google signup flow.
65c96baefa Call new method when bumping account created stat.
afedb2008a bumped google play services version to 15.0.1
853823cd9a Merge pull request #217 from woocommerce/feature/113-login-notification
848294dc29 Use more generic naming for the login notification channel id
fa437d344f Merge commit '09a0852581dd9a3a6b15109f3a8e9a80e644fbbb' into feature/update-login-library
6b07a925db Enable Google login
066beded26 Update gradle plugin to 3.1.2
3e1abf1cf0 Fix FluxC build error in login library
37707a744c Merge pull request #188 from woocommerce/feature/gradle-3.1.1
1a933195f0 Update gradle plugin and support libraries to latest
9af7502466 Update inner import checkstyle violations in login library
d07401c892 Update IDEA style config files
ad4fc3b429 Revert unintentional color change in the WordPressLoginFlow module.
c1b56716a1 Merge branch 'feature/order-details-screen' into feature/order-detail-views
6c93c92dc5 Exclude utils library from FluxC imports
372719093e Merge branch 'develop' into feature/order-detail-views
eec28986b5 Restore login notification styling changes
103dd8f6a1 Merge commit '6bd01d64a2d01176f5b26ae36836d4f5ff0fcdc9' into feature/update-login-lib
97462cca8e Merge branch 'develop' into feature/order-detail-views
20e9f3b9e3 Move login icon colors to variables
b15f6632fa Merge branch 'develop' into feature/114-login-style-refactor
26d1088134 Fix style violations in login library
17326beace Order Details - Customer Info View - Action Icons and listeners, updated icon assets * Add the ability to click to dial customer phone * Add the ability to click to email customer * Add the ability to click to sms customer
ebfa842faf Make login notification styling overridable
5494d0e742 Make login toolbar styling overridable
8cbdb5b313 Use overridable color names in login flow styles
e9137fe9f7 Replace WordPress buttons with LoginTheme
bf34dabb71 Expose play-services-auth dependency from login library
19203891d7 Merge commit '9751124a62caad5f7c9af772f8b872b604cd02b9' into feature/gradle-3.0
f5b58af6b4 Add WPCOM_LOGIN_ONLY LoginMode, disallowing self-hosted login

git-subtree-dir: libs/login
git-subtree-split: 4896a91c7cb62100a663fd879915eff73f39a27e
wzieba pushed a commit that referenced this issue Sep 27, 2024
@oguzkocer
Merge pull request #7880 from /issues/7856-refresh-meta-data
db5d6f7 
Issues/7856 refresh meta data
wzieba pushed a commit that referenced this issue Oct 21, 2024
@oguzkocer
Merge pull request #7880 from /issues/7856-refresh-meta-data
6a06fbf 
Issues/7856 refresh meta data
wzieba pushed a commit that referenced this issue Oct 21, 2024
@oguzkocer
Merge pull request #7880 from /issues/7856-refresh-meta-data
3c5f746 
Issues/7856 refresh meta data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aerych aerych

Labels
Signup
Projects
None yet
Milestone
10.2
Development

No branches or pull requests
2 participants
@aerych @loremattei