Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pages: confusing error dialog #311

Closed
nbradbury opened this issue Nov 16, 2013 · 4 comments · Fixed by #568
Closed

Pages: confusing error dialog #311

nbradbury opened this issue Nov 16, 2013 · 4 comments · Fixed by #568
Assignees
@maxme
Milestone
2.6

Comments

@nbradbury
Copy link
Contributor

I tapped "Pages" in the sidebar while in airplane mode and was presented with this dialog. Selecting "Yes" results in the same error dialog.

Nexus 7, Android 4.3.

device-2013-11-15-200643
@maxme
Copy link
Contributor

maxme commented Dec 13, 2013

Note: title must be more friendly

@maxme
Copy link
Contributor

maxme commented Dec 13, 2013

R.string.error_refresh is not translation friendly. (see https://github.com/wordpress-mobile/WordPress-Android/blob/develop/res/values/strings.xml?source=c#L607)

wpid-screenshot_2013-12-13-14-45-07

@xknown
Copy link

xknown commented Dec 20, 2013

On Nexus 5, WP Android 2.6 Beta 1, clicking Yes sometimes crashes the application. Is there a way to grab the stack trace?

@xknown
Copy link

xknown commented Dec 20, 2013

I was able to reproduce the crash consistently. The CrashRerport mentions that in the following line a CommentsActivity object couldn't be casted to an OnDialogConfirmListener object.

WordPress-Android/src/org/wordpress/android/util/WPAlertDialogFragment.java

Line 142 in 41b4742

OnDialogConfirmListener act = (OnDialogConfirmListener) getActivity();

@ghost ghost assigned maxme Dec 21, 2013
maxme added a commit that referenced this issue Dec 23, 2013
@maxme
fix #311: replace confusing error dialog by a toast
d88f0ff 
* replace confusing error dialog by a toast
* fix an i18n issue with "error_refresh" messages
* unification of refresh messages (Toast everywhere: notificaitons, comments, pages, posts, media, themes) not sure about stats: #567
@maxme maxme mentioned this issue Dec 23, 2013
Merged
roundhill added a commit that referenced this issue Dec 23, 2013
@roundhill
Merge pull request #568 from wordpress-mobile/issue/311-confusing-err…
bd410de 
…or-dialogs

fix #311: replace confusing error dialog by a toast
maxme added a commit that referenced this issue Mar 8, 2016
@maxme
Squashed 'libs/editor/' changes from 2b066be..eb8d070
8db246f 
eb8d070 Merge pull request #311 from wordpress-mobile/issue/310-add-labels-to-link-edittext
6c99e24 wrap DialogLink's EditText inside TextInputLayout

git-subtree-dir: libs/editor
git-subtree-split: eb8d070e013e9c9ce30d20ba28825831b4689e79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxme maxme

Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging a pull request may close this issue.

fix #311: replace confusing error dialog by a toast wordpress-mobile/WordPress-Android
3 participants
@maxme @xknown @nbradbury