Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Violation Comments to GitHub Gradle Plugin Not Working #14051

Closed
ParaskP7 opened this issue Feb 12, 2021 · 2 comments · Fixed by #14059
Closed

Violation Comments to GitHub Gradle Plugin Not Working #14051

ParaskP7 opened this issue Feb 12, 2021 · 2 comments · Fixed by #14059
Labels
Tooling

Comments

@ParaskP7
Copy link
Contributor

Expected behavior

The Violation Comments to GitHub Gradle Plugin should comment on a PR with CheckStyle issues.

Actual behavior

The Violation Comments to GitHub Gradle Plugin doesn't comment on a PR with CheckStyle issues.

Steps to reproduce the behavior

This #14033 PR reproduces it.

Tested on [device], Android [version], WPAndroid [version]

Tested on this #14033 PR.
@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

1 similar comment
@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@ParaskP7 ParaskP7 mentioned this issue Feb 12, 2021
Closed
ParaskP7 added a commit that referenced this issue Feb 12, 2021
@ParaskP7
Build: Revert violation config changes
7226b78 
After testing the 'Violation Comments' plugin it seems that the plugin
is not working as expected. As thus, any additional configuration is
being reverted. This additional configuration will be added back again
when the plugin gets back to work a working state.

Link: #14051
@loremattei loremattei mentioned this issue Feb 12, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/lint pr annotations wordpress-mobile/WordPress-Android
1 participant
@ParaskP7