Skip to content

Commit

Permalink
Deps: Add google flexbox transitively used dependencies on wordpress
Browse files Browse the repository at this point in the history
It is generally recommended that transitively used dependencies should
be declared directly.

------------------------------------------------------------------------

Actually, updating 'Zendesk', which was the dependency that was
providing this transitively used 'Flexbox' dependency to the project,
was causing a compilation failure. This is due to the fact that the
[BloggingPromptsOnboardingDialogFragment],
[BloggingPromptCardViewHolder] and [WPEditTextWithChipsOutlined] classes
are directly using this dependency, but could no longer resolve it.

PS: This is (most probably) due to the fact that this 'Flexbox'
dependency was no longer available on newer 'Zendesk' versions.
  • Loading branch information
ParaskP7 committed Mar 13, 2023
1 parent 8978997 commit 8a7dc7e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions WordPress/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ dependencies {
implementation "androidx.cardview:cardview:$androidxCardviewVersion"
implementation "androidx.recyclerview:recyclerview:$androidxRecyclerviewVersion"
implementation "com.google.android.material:material:$googleMaterialVersion"
implementation "com.google.android.flexbox:flexbox:$googleFlexboxlayoutVersion"
implementation "androidx.percentlayout:percentlayout:$androidxPercentlayoutVersion"
implementation "androidx.swiperefreshlayout:swiperefreshlayout:$androidxSwipeToRefreshVersion"
implementation "androidx.preference:preference:$androidxPreferenceVersion"
Expand Down
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ ext {
glideVolleyVersion = '4.6.1@aar'
googleAutoServiceVersion = '1.0'
googleExoPlayerVersion = '2.13.3'
googleFlexboxlayoutVersion = '3.0.0'
googleGsonVersion = '2.6.2'
googleMaterialVersion = '1.2.1'
googleMLKitBarcodeScanningVersion = '17.0.0'
Expand Down

0 comments on commit 8a7dc7e

Please sign in to comment.