Skip to content

Commit

Permalink
Deps: Remove dagger exclusion from zendesk dependency
Browse files Browse the repository at this point in the history
This 'exclude' related configuration was added back in Jun 13, 2018
while migrating 'Zendesk' to v2 of 'Zendesk' SDK, or else replacing
'Helpshift' with 'Zendesk' (a13b646).

Back then, it was probably necessary to exclude 'Dagger' to have the
project compile (due to duplicate classpath error or otherwise).

However, it seems that it is no longer necessary to have such a
configuration where 'Dagger' is excluded. As such, this change is
reverted. As long as the project compiles and 'Zendesk' works as
expected, this change can be consider safe.
  • Loading branch information
ParaskP7 committed Mar 13, 2023
1 parent 4a099b8 commit 37cacda
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions WordPress/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -439,9 +439,7 @@ dependencies {
implementation "androidx.lifecycle:lifecycle-viewmodel-compose:$androidxComposeLifecycleVersion"
implementation "io.coil-kt:coil-compose:$coilComposeVersion"
implementation ('com.github.indexos.media-for-mobile:android:43a9026f0973a2f0a74fa813132f6a16f7499c3a')
implementation (group: 'com.zendesk', name: 'support', version: "$zendeskVersion") {
exclude group: 'com.google.dagger'
}
implementation (group: 'com.zendesk', name: 'support', version: "$zendeskVersion")
implementation (name:'tenor-android-core-jetified', ext:'aar') // Jetified Tenor Gif library
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:$kotlinxCoroutinesVersion"
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:$kotlinxCoroutinesVersion"
Expand Down

0 comments on commit 37cacda

Please sign in to comment.