Skip to content

Commit

Permalink
Do not track "dismissed" and "ignored" PNs to be in par with iOS.
Browse files Browse the repository at this point in the history
  • Loading branch information
daniloercoli committed Dec 3, 2015
1 parent bb03085 commit 3067bf5
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ public enum Stat {
STATS_SELECTED_INSTALL_JETPACK,
PUSH_NOTIFICATION_RECEIVED,
PUSH_NOTIFICATION_TAPPED, // Same of opened
PUSH_NOTIFICATION_DISMISSED, // Dismissed by the user
PUSH_NOTIFICATION_IGNORED, // The user opened the app without interacting with the notification(s)
SUPPORT_OPENED_HELPSHIFT_SCREEN,
SUPPORT_SENT_REPLY_TO_SUPPORT_MESSAGE,
LOGIN_FAILED,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -691,14 +691,6 @@ private AnalyticsTrackerMixpanelInstructionsForStat instructionsForStat(
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Push Notification Tapped");
break;
case PUSH_NOTIFICATION_DISMISSED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Push Notification Dismissed");
break;
case PUSH_NOTIFICATION_IGNORED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Push Notification Ignored");
break;
case SUPPORT_OPENED_HELPSHIFT_SCREEN:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Support - Opened Helpshift Screen");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -306,12 +306,6 @@ public void track(AnalyticsTracker.Stat stat, Map<String, ?> properties) {
case PUSH_NOTIFICATION_TAPPED:
eventName = "push_notification_tapped";
break;
case PUSH_NOTIFICATION_DISMISSED:
eventName = "push_notification_dismissed";
break;
case PUSH_NOTIFICATION_IGNORED:
eventName = "push_notification_ignored";
break;
case SUPPORT_OPENED_HELPSHIFT_SCREEN:
eventName = "support_helpshift_screen_opened";
break;
Expand Down

0 comments on commit 3067bf5

Please sign in to comment.