Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when displaying an empty view #409

Merged
merged 3 commits into from
May 13, 2023
Merged

Fix crash when displaying an empty view #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a6873b
Update: correctly configure the empty view if the delegate returns nil
hassaanelgarem May 12, 2023
cab8e93
Update: bump podspec version
hassaanelgarem May 12, 2023
ec079cc
Run pod install to point to the new podspec
hassaanelgarem May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Example/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PODS:
- WPMediaPicker (1.8.7)
- WPMediaPicker (1.8.8-beta.1)

DEPENDENCIES:
- WPMediaPicker (from `../`)
Expand All @@ -9,7 +9,7 @@ EXTERNAL SOURCES:
:path: "../"

SPEC CHECKSUMS:
WPMediaPicker: 0d45dfd7b3c5651c5236ffd48c1b0b2f60a2d5d2
WPMediaPicker: 3b0d7272bec6eb0d8bc267daa5606c9b259e6cbb

PODFILE CHECKSUM: 31590cb12765a73c9da27d6ea5b8b127c095d71d

Expand Down
3 changes: 2 additions & 1 deletion Pod/Classes/WPMediaPickerViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,8 @@ - (UIViewController *)emptyViewController
if ([self usingEmptyViewController]) {
_emptyViewController = [self.mediaPickerDelegate emptyViewControllerForMediaPickerController:self];
}
else {

if (_emptyViewController == nil) {
_emptyViewController = self.defaultEmptyViewController;
}

Expand Down
2 changes: 1 addition & 1 deletion WPMediaPicker.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Pod::Spec.new do |s|
s.name = 'WPMediaPicker'
s.version = '1.8.7'
s.version = '1.8.8-beta.1'

s.summary = 'WPMediaPicker is an iOS controller that allows capture and picking of media assets.'
s.description = <<-DESC
Expand Down